Merge branch '267993-enable-by-default-true-in-api-helper-usage_data_-event-feature' into 'master'

Enable by default true in API helper usage_data_#{event} feature

See merge request gitlab-org/gitlab!48607

changelogs/unreleased/267993-enable-by-default-true-in-api-helper-usage_data_-event-feature.yml

+---
+title: Enable by default usage data API tracking
+merge_request: 48607
+author:
+type: added

config/feature_flags/development/usage_data_a_compliance_audit_events_api.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/233786
 milestone: '13.4'
 type: development
 group: group::compliance
-default_enabled: false
+default_enabled: true

config/feature_flags/development/usage_data_g_compliance_dashboard.yml

 ---
 name: usage_data_g_compliance_dashboard
-introduced_by_url: 
-rollout_issue_url: 
-milestone: 
+introduced_by_url:
+rollout_issue_url:
+milestone:
 type: development
 group: group::compliance
-default_enabled: false
+default_enabled: true

lib/api/helpers.rb

@@ -550,8 +550,9 @@ module API
     def increment_unique_values(event_name, values)
       return unless values.present?
 
-      feature_name = "usage_data_#{event_name}"
-      return unless Feature.enabled?(feature_name)
+      feature_flag = "usage_data_#{event_name}"
+
+      return unless Feature.enabled?(feature_flag, default_enabled: true)
 
       Gitlab::UsageDataCounters::HLLRedisCounter.track_event(values, event_name)
     rescue => error