Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
716123a9
Commit
716123a9
authored
Mar 25, 2021
by
Michelle Gill
Committed by
Phil Hughes
Mar 25, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update Code Review process to use Reviewers
parent
761a8b63
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
41 additions
and
25 deletions
+41
-25
doc/development/code_review.md
doc/development/code_review.md
+37
-22
doc/development/database_review.md
doc/development/database_review.md
+4
-3
No files found.
doc/development/code_review.md
View file @
716123a9
This diff is collapsed.
Click to expand it.
doc/development/database_review.md
View file @
716123a9
...
@@ -67,8 +67,8 @@ A database **reviewer**'s role is to:
...
@@ -67,8 +67,8 @@ A database **reviewer**'s role is to:
-
Ensure the
[
required
](
#required
)
artifacts are provided and in the proper format. If they are not, reassign the merge request back to the author.
-
Ensure the
[
required
](
#required
)
artifacts are provided and in the proper format. If they are not, reassign the merge request back to the author.
-
Perform a first-pass review on the MR and suggest improvements to the author.
-
Perform a first-pass review on the MR and suggest improvements to the author.
-
Once satisfied, relabel the MR with ~"database::reviewed", approve it, and
-
Once satisfied, relabel the MR with ~"database::reviewed", approve it, and
re
assign MR to
the database
**maintainer**
suggested by Reviewer
re
quest a review from
the database
**maintainer**
suggested by Reviewer
Roulette.
Roulette.
Remove yourself as a reviewer once this has been done.
A database
**maintainer**
's role is to:
A database
**maintainer**
's role is to:
...
@@ -78,12 +78,13 @@ A database **maintainer**'s role is to:
...
@@ -78,12 +78,13 @@ A database **maintainer**'s role is to:
-
Finally approve the MR and relabel the MR with ~"database::approved"
-
Finally approve the MR and relabel the MR with ~"database::approved"
-
Merge the MR if no other approvals are pending or pass it on to
-
Merge the MR if no other approvals are pending or pass it on to
other maintainers as required (frontend, backend, docs).
other maintainers as required (frontend, backend, docs).
-
If not merging, remove yourself as a reviewer.
### Distributing review workload
### Distributing review workload
Review workload is distributed using
[
reviewer roulette
](
code_review.md#reviewer-roulette
)
Review workload is distributed using
[
reviewer roulette
](
code_review.md#reviewer-roulette
)
(
[
example
](
https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/25181#note_147551725
)
).
(
[
example
](
https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/25181#note_147551725
)
).
The MR author should
then co-assign
the suggested database
The MR author should
request a review from
the suggested database
**reviewer**
. When they give their sign-off, they will hand over to
**reviewer**
. When they give their sign-off, they will hand over to
the suggested database
**maintainer**
.
the suggested database
**maintainer**
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment