Merge branch 'eb-remove-ff-350609' into 'master'

Remove bulk_expire_project_artifacts feature flag

See merge request gitlab-org/gitlab!83509

config/feature_flags/development/bulk_expire_project_artifacts.yml

----
-name: bulk_expire_project_artifacts
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75488
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/347405
-milestone: '14.6'
-type: development
-group: group::pipeline insights
-default_enabled: true

doc/api/job_artifacts.md

@@ -287,11 +287,8 @@ If the artifacts were deleted successfully, a response with status `204 No Conte
 
 ## Delete project artifacts
 
-> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/223793) in GitLab 14.7 [with a flag](../administration/feature_flags.md) named `bulk_expire_project_artifacts`. Enabled by default on GitLab self-managed. Enabled on GitLab.com.
-
-FLAG:
-On self-managed GitLab, by default this feature is available. To hide the feature, ask an administrator to
-[disable the `bulk_expire_project_artifacts` flag](../administration/feature_flags.md). On GitLab.com, this feature is available.
+> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/223793) in GitLab 14.7 [with a flag](../administration/feature_flags.md) named `bulk_expire_project_artifacts`. Enabled by default on GitLab self-managed. Enabled on GitLab.com.
+> - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/issues/350609) in GitLab 14.10.
 
 Delete artifacts of a project that can be deleted.
 

lib/api/ci/job_artifacts.rb

@@ -140,8 +140,6 @@ module API
 
         desc 'Expire the artifacts files from a project'
         delete ':id/artifacts' do
-          not_found! unless Feature.enabled?(:bulk_expire_project_artifacts, default_enabled: :yaml)
-
           authorize_destroy_artifacts!
 
           ::Ci::JobArtifacts::DeleteProjectArtifactsService.new(project: user_project).execute

spec/requests/api/ci/job_artifacts_spec.rb

@@ -82,18 +82,6 @@ RSpec.describe API::Ci::JobArtifacts do
   end
 
   describe 'DELETE /projects/:id/artifacts' do
-    context 'when feature flag is disabled' do
-      before do
-        stub_feature_flags(bulk_expire_project_artifacts: false)
-      end
-
-      it 'returns 404' do
-        delete api("/projects/#{project.id}/artifacts", api_user)
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'when user is anonymous' do
       let(:api_user) { nil }