Commit 71eac33b authored by Miguel Rincon's avatar Miguel Rincon

Remove computed props checks from pipelines specs

Pipelines specs refactor to improve:
- Removing internal checks such as computed propos
- Triggering events instead of invoking methods
- Replace find() calls to use finder methods
parent 47c0f61b
......@@ -48,6 +48,7 @@ export default {
variant="info"
category="primary"
class="js-get-started-pipelines"
data-testid="get-started-pipelines"
>
{{ s__('Pipelines|Get started with Pipelines') }}
</gl-button>
......
......@@ -46,6 +46,7 @@ export default {
variant="success"
category="primary"
class="js-run-pipeline"
data-testid="run-pipeline-button"
>
{{ s__('Pipelines|Run Pipeline') }}
</gl-button>
......@@ -54,12 +55,13 @@ export default {
v-if="resetCachePath"
:loading="isResetCacheButtonLoading"
class="js-clear-cache"
data-testid="clear-cache-button"
@click="onClickResetCache"
>
{{ s__('Pipelines|Clear Runner Caches') }}
</gl-button>
<gl-button v-if="ciLintPath" :href="ciLintPath" class="js-ci-lint">
<gl-button v-if="ciLintPath" :href="ciLintPath" class="js-ci-lint" data-testid="ci-lint-button">
{{ s__('Pipelines|CI Lint') }}
</gl-button>
</div>
......
......@@ -58,7 +58,12 @@ export default {
active: tab.isActive,
}"
>
<a :class="`js-${scope}-tab-${tab.scope}`" role="button" @click="onTabClick(tab)">
<a
:class="`js-${scope}-tab-${tab.scope}`"
:data-testid="`${scope}-tab-${tab.scope}`"
role="button"
@click="onTabClick(tab)"
>
{{ tab.name }}
<span v-if="shouldRenderBadge(tab.count)" class="badge badge-pill"> {{ tab.count }} </span>
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment