Merge branch 'mo-remove-ci-features-module' into 'master'

Remove Gitlab::Ci::Features

See merge request gitlab-org/gitlab!75502

app/services/auto_merge/base_service.rb

@@ -64,7 +64,7 @@ module AutoMerge
     # NOTE: This method is to be removed when `disallow_to_create_merge_request_pipelines_in_target_project`
     # feature flag is removed.
     def self.can_add_to_merge_train?(merge_request)
-      if Gitlab::Ci::Features.disallow_to_create_merge_request_pipelines_in_target_project?(merge_request.target_project)
+      if ::Feature.enabled?(:ci_disallow_to_create_merge_request_pipelines_in_target_project, merge_request.target_project)
         merge_request.for_same_project?
       else
         true

app/services/ci/update_build_state_service.rb

@@ -216,11 +216,12 @@ module Ci
     end
 
     def chunks_migration_enabled?
-      ::Gitlab::Ci::Features.accept_trace?(build.project)
+      ::Feature.enabled?(:ci_enable_live_trace, build.project) &&
+        ::Feature.enabled?(:ci_accept_trace, build.project, type: :ops, default_enabled: true)
     end
 
     def log_invalid_chunks?
-      ::Gitlab::Ci::Features.log_invalid_trace_chunks?(build.project)
+      ::Feature.enabled?(:ci_trace_log_invalid_chunks, build.project, type: :ops, default_enabled: false)
     end
   end
 end

app/services/merge_requests/create_pipeline_service.rb

@@ -48,7 +48,7 @@ module MergeRequests
     end
 
     def can_create_pipeline_in_target_project?(merge_request)
-      if Gitlab::Ci::Features.disallow_to_create_merge_request_pipelines_in_target_project?(merge_request.target_project)
+      if ::Feature.enabled?(:ci_disallow_to_create_merge_request_pipelines_in_target_project, merge_request.target_project)
         merge_request.for_same_project?
       else
         can?(current_user, :create_pipeline, merge_request.target_project) &&

lib/gitlab/ci/features.rb

-# frozen_string_literal: true
-
-module Gitlab
-  module Ci
-    ##
-    # Deprecated: Ci::Features is a class that aggregates all CI/CD feature flags in one place.
-    #
-    module Features
-      # NOTE: The feature flag `disallow_to_create_merge_request_pipelines_in_target_project`
-      # is a safe switch to disable the feature for a particular project when something went wrong,
-      # therefore it's not supposed to be enabled by default.
-      def self.disallow_to_create_merge_request_pipelines_in_target_project?(target_project)
-        ::Feature.enabled?(:ci_disallow_to_create_merge_request_pipelines_in_target_project, target_project)
-      end
-
-      def self.accept_trace?(project)
-        ::Feature.enabled?(:ci_enable_live_trace, project) &&
-          ::Feature.enabled?(:ci_accept_trace, project, type: :ops, default_enabled: true)
-      end
-
-      def self.log_invalid_trace_chunks?(project)
-        ::Feature.enabled?(:ci_trace_log_invalid_chunks, project, type: :ops, default_enabled: false)
-      end
-
-      def self.gldropdown_tags_enabled?
-        ::Feature.enabled?(:gldropdown_tags, default_enabled: :yaml)
-      end
-    end
-  end
-end