Merge branch '227838-h3-h4-class-fix' into 'master'

Replace mis-used CSS class

Closes #227838

See merge request gitlab-org/gitlab!39338

app/assets/javascripts/incidents_settings/components/incidents_settings_tabs.vue

@@ -24,9 +24,9 @@ export default {
     class="settings no-animate qa-incident-management-settings"
   >
     <div class="settings-header">
-      <h3 ref="sectionHeader" class="h4">
+      <h4 ref="sectionHeader" class="gl-my-3! gl-py-1">
         {{ $options.i18n.headerText }}
-      </h3>
+      </h4>
       <gl-button ref="toggleBtn" class="js-settings-toggle">{{
         $options.i18n.expandBtnLabel
       }}</gl-button>

changelogs/unreleased/227838-h3-h4-class-fix.yml

+---
+title: Replace mis-used CSS class in operations settings
+merge_request: 39338
+author:
+type: changed

ee/app/assets/javascripts/status_page_settings/components/settings_form.vue

@@ -75,9 +75,9 @@ export default {
 <template>
   <section id="status-page" class="settings no-animate js-status-page-settings">
     <div class="settings-header">
-      <h3 ref="sectionHeader" class="h4">
+      <h4 ref="sectionHeader" class="gl-my-3! gl-py-1">
         {{ $options.i18n.headerText }}
-      </h3>
+      </h4>
       <gl-button ref="toggleBtn" class="js-settings-toggle">{{
         $options.i18n.expandBtnLabel
       }}</gl-button>

ee/spec/frontend/status_page_settings/__snapshots__/settings_form_spec.js.snap

@@ -8,13 +8,13 @@ exports[`Status Page settings form default state should match the default snapsh
   <div
     class="settings-header"
   >
-    <h3
-      class="h4"
+    <h4
+      class="gl-my-3! gl-py-1"
     >
       
       Status page
     
-    </h3>
+    </h4>
      
     <gl-button-stub
       class="js-settings-toggle"

spec/features/projects/settings/operations_settings_spec.rb

@@ -35,7 +35,7 @@ RSpec.describe 'Projects > Settings > For a forked project', :js do
       end
 
       it 'renders form for incident management' do
-        expect(page).to have_selector('h3', text: 'Incidents')
+        expect(page).to have_selector('h4', text: 'Incidents')
       end
 
       it 'sets correct default values' do

spec/frontend/incidents_settings/components/__snapshots__/incidents_settings_tabs_spec.js.snap

@@ -9,13 +9,13 @@ exports[`IncidentsSettingTabs should render the component 1`] = `
   <div
     class="settings-header"
   >
-    <h3
-      class="h4"
+    <h4
+      class="gl-my-3! gl-py-1"
     >
       
       Incidents
     
-    </h3>
+    </h4>
      
     <gl-button-stub
       category="tertiary"