Merge branch 'caw-remove-snippet-spam-flag' into 'master'

Remove snippet_spam feature flag

See merge request gitlab-org/gitlab!66118

app/services/snippets/create_service.rb

@@ -20,14 +20,12 @@ module Snippets
 
       @snippet.author = current_user
 
-      if Feature.enabled?(:snippet_spam)
-        Spam::SpamActionService.new(
-          spammable: @snippet,
-          spam_params: spam_params,
-          user: current_user,
-          action: :create
-        ).execute
-      end
+      Spam::SpamActionService.new(
+        spammable: @snippet,
+        spam_params: spam_params,
+        user: current_user,
+        action: :create
+      ).execute
 
       if save_and_commit
         UserAgentDetailService.new(spammable: @snippet, spam_params: spam_params).create

app/services/snippets/update_service.rb

@@ -23,14 +23,12 @@ module Snippets
 
       update_snippet_attributes(snippet)
 
-      if Feature.enabled?(:snippet_spam)
-        Spam::SpamActionService.new(
-          spammable: snippet,
-          spam_params: spam_params,
-          user: current_user,
-          action: :update
-        ).execute
-      end
+      Spam::SpamActionService.new(
+        spammable: snippet,
+        spam_params: spam_params,
+        user: current_user,
+        action: :update
+      ).execute
 
       if save_and_commit(snippet)
         Gitlab::UsageDataCounters::SnippetCounter.count(:update)

config/feature_flags/development/snippet_spam.yml

----
-name: snippet_spam
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/44010
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/262013
-milestone: '13.5'
-type: development
-group: group::editor
-default_enabled: false

spec/support/shared_examples/services/snippets_shared_examples.rb

@@ -22,18 +22,6 @@ RSpec.shared_examples 'checking spam' do
 
     subject
   end
-
-  context 'when snippet_spam flag is disabled' do
-    before do
-      stub_feature_flags(snippet_spam: false)
-    end
-
-    it 'request parameter is not passed to the service' do
-      expect(Spam::SpamActionService).not_to receive(:new)
-
-      subject
-    end
-  end
 end
 
 shared_examples 'invalid params error response' do