Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
746e49fe
Commit
746e49fe
authored
Nov 03, 2015
by
Anton Baklanov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Display target branch on MR list when it is different from project's default
parent
2ee3f838
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
36 additions
and
0 deletions
+36
-0
CHANGELOG
CHANGELOG
+1
-0
app/controllers/projects/merge_requests_controller.rb
app/controllers/projects/merge_requests_controller.rb
+1
-0
app/views/projects/merge_requests/_merge_request.html.haml
app/views/projects/merge_requests/_merge_request.html.haml
+5
-0
features/project/merge_requests.feature
features/project/merge_requests.feature
+9
-0
features/steps/project/merge_requests.rb
features/steps/project/merge_requests.rb
+20
-0
No files found.
CHANGELOG
View file @
746e49fe
...
@@ -28,6 +28,7 @@ v 8.2.0 (unreleased)
...
@@ -28,6 +28,7 @@ v 8.2.0 (unreleased)
- Allow groups to appear in the search results if the group owner allows it
- Allow groups to appear in the search results if the group owner allows it
- New design for project graphs page
- New design for project graphs page
- Fix incoming email config defaults
- Fix incoming email config defaults
- MR target branch is now visible on a list view when it is different from project's default one
v 8.1.4
v 8.1.4
- Fix bug where manually merged branches in a MR would end up with an empty diff (Stan Hu)
- Fix bug where manually merged branches in a MR would end up with an empty diff (Stan Hu)
...
...
app/controllers/projects/merge_requests_controller.rb
View file @
746e49fe
...
@@ -31,6 +31,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController
...
@@ -31,6 +31,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController
end
end
@merge_requests
=
@merge_requests
.
page
(
params
[
:page
]).
per
(
PER_PAGE
)
@merge_requests
=
@merge_requests
.
page
(
params
[
:page
]).
per
(
PER_PAGE
)
@merge_requests
=
@merge_requests
.
preload
(
:target_project
)
respond_to
do
|
format
|
respond_to
do
|
format
|
format
.
html
format
.
html
...
...
app/views/projects/merge_requests/_merge_request.html.haml
View file @
746e49fe
...
@@ -41,6 +41,11 @@
...
@@ -41,6 +41,11 @@
%span
%span
%i
.fa.fa-clock-o
%i
.fa.fa-clock-o
=
merge_request
.
milestone
.
title
=
merge_request
.
milestone
.
title
-
if
merge_request
.
target_project
.
default_branch
!=
merge_request
.
target_branch
%span
%i
.fa.fa-code-fork
=
merge_request
.
target_branch
-
if
merge_request
.
tasks?
-
if
merge_request
.
tasks?
%span
.task-status
%span
.task-status
=
merge_request
.
task_status
=
merge_request
.
task_status
...
...
features/project/merge_requests.feature
View file @
746e49fe
...
@@ -16,6 +16,15 @@ Feature: Project Merge Requests
...
@@ -16,6 +16,15 @@ Feature: Project Merge Requests
When
I visit project
"Shop"
merge requests page
When
I visit project
"Shop"
merge requests page
Then
I should see merge request
"Bug NS-05"
with CI status
Then
I should see merge request
"Bug NS-05"
with CI status
Scenario
:
I
should not see target branch name when it is project's default branch
Then
I should see
"Bug NS-04"
in merge requests
And
I should not see
"master"
branch
Scenario
:
I
should see target branch when it is different from default
Given
project
"Shop"
have
"Bug NS-06"
open merge request
When
I visit project
"Shop"
merge requests page
Then
I should see
"other_branch"
branch
Scenario
:
I
should see rejected merge requests
Scenario
:
I
should see rejected merge requests
Given
I click link
"Closed"
Given
I click link
"Closed"
Then
I should see
"Feature NS-03"
in merge requests
Then
I should see
"Feature NS-03"
in merge requests
...
...
features/steps/project/merge_requests.rb
View file @
746e49fe
...
@@ -40,6 +40,14 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
...
@@ -40,6 +40,14 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
expect
(
page
).
to
have_content
"Bug NS-04"
expect
(
page
).
to
have_content
"Bug NS-04"
end
end
step
'I should not see "master" branch'
do
expect
(
page
).
not_to
have_content
"master"
end
step
'I should see "other_branch" branch'
do
expect
(
page
).
to
have_content
"other_branch"
end
step
'I should see "Bug NS-04" in merge requests'
do
step
'I should see "Bug NS-04" in merge requests'
do
expect
(
page
).
to
have_content
"Bug NS-04"
expect
(
page
).
to
have_content
"Bug NS-04"
end
end
...
@@ -93,6 +101,18 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
...
@@ -93,6 +101,18 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
)
)
end
end
step
'project "Shop" have "Bug NS-06" open merge request'
do
create
(
:merge_request
,
title:
"Bug NS-06"
,
source_project:
project
,
target_project:
project
,
source_branch:
'fix'
,
target_branch:
'other_branch'
,
author:
project
.
users
.
first
,
description:
"# Description header"
)
end
step
'project "Shop" have "Bug NS-05" open merge request with diffs inside'
do
step
'project "Shop" have "Bug NS-05" open merge request with diffs inside'
do
create
(
:merge_request_with_diffs
,
create
(
:merge_request_with_diffs
,
title:
"Bug NS-05"
,
title:
"Bug NS-05"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment