Merge branch 'al-rubocop-inline-association-audit-events' into 'master'

Fix cop FactoryBot/InlineAssociation for audit_events

See merge request gitlab-org/gitlab!45806

.rubocop_todo.yml

@@ -1269,7 +1269,6 @@ FactoryBot/InlineAssociation:
     - 'ee/spec/factories/resource_weight_events.rb'
     - 'ee/spec/factories/vulnerabilities/feedback.rb'
     - 'spec/factories/atlassian_identities.rb'
-    - 'spec/factories/audit_events.rb'
     - 'spec/factories/design_management/design_at_version.rb'
     - 'spec/factories/design_management/designs.rb'
     - 'spec/factories/design_management/versions.rb'

spec/factories/audit_events.rb

@@ -4,7 +4,7 @@ FactoryBot.define do
   factory :audit_event, class: 'AuditEvent', aliases: [:user_audit_event] do
     user
 
-    transient { target_user { create(:user) } }
+    transient { target_user { association(:user) } }
 
     entity_type { 'User' }
     entity_id   { target_user.id }
@@ -27,7 +27,7 @@ FactoryBot.define do
     end
 
     trait :project_event do
-      transient { target_project { create(:project) } }
+      transient { target_project { association(:project) } }
 
       entity_type { 'Project' }
       entity_id   { target_project.id }
@@ -50,7 +50,7 @@ FactoryBot.define do
     end
 
     trait :group_event do
-      transient { target_group { create(:group) } }
+      transient { target_group { association(:group) } }
 
       entity_type { 'Group' }
       entity_id   { target_group.id }