Merge branch '202590-migrate-spinner-for-app/views/shared/issuable' into 'master'

Migrate '.fa-spinner' to '.spinner' for 'app/views/shared/issuable'

Closes #202590

See merge request gitlab-org/gitlab!41132

app/assets/stylesheets/pages/issuable.scss

@@ -919,12 +919,12 @@
 }
 
 .issuable-todo-btn {
-  .fa-spinner {
+  .gl-spinner {
     display: none;
   }
 
   &.is-loading {
-    .fa-spinner {
+    .gl-spinner {
       display: inline-block;
     }
 

app/views/shared/issuable/_sidebar.html.haml

@@ -63,7 +63,7 @@
             // Fallback while content is loading
             .title.hide-collapsed
               = _('Time tracking')
-              = icon('spinner spin', 'aria-hidden': 'true')
+              = loading_icon
         - if issuable_sidebar.has_key?(:due_date)
           .block.due_date
             .sidebar-collapsed-icon.has-tooltip{ data: { placement: 'left', container: 'body', html: 'true', boundary: 'viewport' }, title: sidebar_due_date_tooltip_label(issuable_sidebar[:due_date]) }

app/views/shared/issuable/_sidebar_todo.html.haml

@@ -12,4 +12,4 @@
   data: todo_button_data }
   %span.issuable-todo-inner.js-issuable-todo-inner<
     = is_collapsed ? button_icon : button_title
-  = icon('spin spinner', 'aria-hidden': 'true')
+  = loading_icon

changelogs/unreleased/202590-migrate-spinner-for-app-views-shared-issuable.yml

+---
+title: Migrate '.fa-spinner' to '.spinner' for 'app/views/shared/issuable'
+merge_request: 41132
+author: Gilang Gumilar
+type: changed