Merge branch 'rc/remove_sync_metrics_dashboard_ff' into 'master'

Remove sync_metrics_dashboard feature flag

See merge request gitlab-org/gitlab!47704

app/services/git/branch_hooks_service.rb

@@ -84,7 +84,6 @@ module Git
     end
 
     def enqueue_metrics_dashboard_sync
-      return unless Feature.enabled?(:sync_metrics_dashboards, project)
       return unless default_branch?
 
       ::Metrics::Dashboard::SyncDashboardsWorker.perform_async(project.id)

changelogs/unreleased/rc-remove_sync_metrics_dashboard_ff.yml

+---
+title: Add alerting support for custom dashboards
+merge_request: 47704
+author:
+type: added

config/feature_flags/development/sync_metrics_dashboards.yml

----
-name: sync_metrics_dashboards
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39658
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241793
-milestone: '13.5'
-type: development
-group: group::apm
-default_enabled: false

doc/operations/metrics/dashboards/index.md

@@ -14,9 +14,6 @@ includes a few key metrics, but you can also define your own custom dashboards.
 You may create a [new dashboard from scratch](#add-a-new-dashboard-to-your-project)
 or [duplicate a GitLab-defined Prometheus dashboard](#duplicate-a-gitlab-defined-dashboard).
 
-The metrics as defined below do not support alerts, unlike
-[custom metrics](../index.md#adding-custom-metrics).
-
 ## Add a new dashboard to your project
 
 > UI option [introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/228856) in GitLab 13.3.