Merge branch 'ajk-remove-graphql_lookahead_support' into 'master'

Remove graphql_lookahead_support feature flag

See merge request gitlab-org/gitlab!43438

app/graphql/resolvers/concerns/looks_ahead.rb

@@ -3,8 +3,6 @@
 module LooksAhead
   extend ActiveSupport::Concern
 
-  FEATURE_FLAG = :graphql_lookahead_support
-
   included do
     attr_accessor :lookahead
   end
@@ -16,8 +14,6 @@ module LooksAhead
   end
 
   def apply_lookahead(query)
-    return query unless Feature.enabled?(FEATURE_FLAG)
-
     selection = node_selection
 
     includes = preloads.each.flat_map do |name, requirements|

changelogs/unreleased/ajk-remove-graphql_lookahead_support.yml

+---
+title: Remove graphql_lookahead_support feature flag
+merge_request: 43438
+author:
+type: added

config/feature_flags/development/graphql_lookahead_support.yml

----
-name: graphql_lookahead_support
-introduced_by_url: 
-rollout_issue_url: 
-group: 
-type: development
-default_enabled: false

spec/graphql/resolvers/concerns/looks_ahead_spec.rb

@@ -117,20 +117,6 @@ RSpec.describe LooksAhead do
     query.result
   end
 
-  context 'the feature flag is off' do
-    before do
-      stub_feature_flags(described_class::FEATURE_FLAG => false)
-    end
-
-    it_behaves_like 'a working query on the test schema'
-
-    it 'does not preload labels on issues' do
-      expect(the_user.issues).not_to receive(:preload).with(:labels)
-
-      query.result
-    end
-  end
-
   it 'issues fewer queries than the naive approach' do
     the_user.reload # ensure no attributes are loaded before we begin
     naive = <<-GQL