Merge branch 'leaky-constant-fix-35' into 'master'

Fix leaky constant in master check, attr config, issue connection specs

See merge request gitlab-org/gitlab!32144

.rubocop.yml

@@ -359,9 +359,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb'
     - 'spec/lib/gitlab/database/with_lock_retries_spec.rb'
     - 'spec/lib/gitlab/git/diff_collection_spec.rb'
-    - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb'
-    - 'spec/lib/gitlab/health_checks/master_check_spec.rb'
-    - 'spec/lib/gitlab/import_export/attribute_configuration_spec.rb'
     - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb'
     - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
     - 'spec/lib/gitlab/jira_import/issues_importer_spec.rb'

changelogs/unreleased/leaky-constant-fix-35.yml

+---
+title: Fix leaky constant issue connection, master check and attr config spec
+merge_request: 32144
+author: Rajendra Kadam
+type: fixed

spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb

@@ -9,6 +9,14 @@ describe Gitlab::Graphql::Pagination::Keyset::Connection do
   let(:schema) { GraphQL::Schema.define(query: query_type, mutation: nil)}
   let(:context) { GraphQL::Query::Context.new(query: OpenStruct.new(schema: schema), values: nil, object: nil) }
 
+  before do
+    stub_const('NoPrimaryKey', Class.new(ActiveRecord::Base))
+    NoPrimaryKey.class_eval do
+      self.table_name  = 'no_primary_key'
+      self.primary_key = nil
+    end
+  end
+
   subject(:connection) do
     described_class.new(nodes, { context: context, max_page_size: 3 }.merge(arguments))
   end
@@ -303,9 +311,4 @@ describe Gitlab::Graphql::Pagination::Keyset::Connection do
       end
     end
   end
-
-  class NoPrimaryKey < ActiveRecord::Base
-    self.table_name  = 'no_primary_key'
-    self.primary_key = nil
-  end
 end

spec/lib/gitlab/health_checks/master_check_spec.rb

@@ -6,10 +6,9 @@ require_relative './simple_check_shared'
 describe Gitlab::HealthChecks::MasterCheck do
   let(:result_class) { Gitlab::HealthChecks::Result }
 
-  SUCCESS_CODE = 100
-  FAILURE_CODE = 101
-
   before do
+    stub_const('SUCCESS_CODE', 100)
+    stub_const('FAILURE_CODE', 101)
     described_class.register_master
   end
 

spec/lib/gitlab/import_export/attribute_configuration_spec.rb

@@ -43,7 +43,4 @@ describe 'Import/Export attribute configuration' do
       IMPORT_EXPORT_CONFIG: #{Gitlab::ImportExport.config_file}
     MSG
   end
-
-  class Author < User
-  end
 end