Merge branch 'ee-enable-autocomplete-on-project-snippets' into 'master'

Enable autocomplete on project snippets -- EE merge edition

See merge request !2174

app/assets/javascripts/dispatcher.js

@@ -234,6 +234,8 @@ import AuditLogs from './audit_logs';
         case 'projects:snippets:edit':
         case 'projects:snippets:create':
         case 'projects:snippets:update':
+          new gl.GLForm($('.snippet-form'), true);
+          break;
         case 'snippets:new':
         case 'snippets:edit':
         case 'snippets:create':

app/views/projects/snippets/show.html.haml

@@ -9,4 +9,4 @@
   .row-content-block.top-block.content-component-block
     = render 'award_emoji/awards_block', awardable: @snippet, inline: true
 
-  #notes= render "shared/notes/notes_with_form", :autocomplete => false
+  #notes= render "shared/notes/notes_with_form", :autocomplete => true

spec/features/projects/snippets_spec.rb

@@ -33,20 +33,11 @@ describe 'Project snippets', :js, feature: true do
         visit namespace_project_snippet_path(project.namespace, project, snippets[0])
       end
 
-      it 'should not have autocomplete' do
-        wait_for_requests
-        request_count_before = page.driver.network_traffic.count
-
+      it 'should have autocomplete' do
         find('#note_note').native.send_keys('')
         fill_in 'note[note]', with: '@'
 
-        wait_for_requests
-        request_count_after = page.driver.network_traffic.count
-
-        # This selector probably won't be in place even if autocomplete was enabled
-        # but we want to make sure
-        expect(page).not_to have_selector('.atwho-view')
-        expect(request_count_before).to eq(request_count_after)
+        expect(page).to have_selector('.atwho-view')
       end
     end
   end