Automatic merge of gitlab-org/gitlab-ce master

changelogs/unreleased/56788-unicorn-metric-labels.yml

+---
+title: Clean up unicorn sampler metric labels
+merge_request: 24626
+author: bjk-gitlab
+type: fixed

doc/administration/monitoring/prometheus/gitlab_metrics.md

@@ -48,6 +48,8 @@ The following metrics are available:
 | upload_file_does_not_exist        | Counter   | 10.7 in EE, 11.5 in CE  | Number of times an upload record could not find its file |
 | failed_login_captcha_total        | Gauge | 11.0 | Counter of failed CAPTCHA attempts during login |
 | successful_login_captcha_total    | Gauge | 11.0 | Counter of successful CAPTCHA attempts during login |
+| unicorn_active_connections        | Gauge | 11.0 | The number of active Unicorn connections (workers) |
+| unicorn_queued_connections        | Gauge | 11.0 | The number of queued Unicorn connections |
 
 ## Sidekiq Metrics available
 

lib/gitlab/metrics/samplers/unicorn_sampler.rb

@@ -23,13 +23,13 @@ module Gitlab
 
         def sample
           Raindrops::Linux.tcp_listener_stats(tcp_listeners).each do |addr, stats|
-            unicorn_active_connections.set({ type: 'tcp', address: addr }, stats.active)
-            unicorn_queued_connections.set({ type: 'tcp', address: addr }, stats.queued)
+            unicorn_active_connections.set({ socket_type: 'tcp', socket_address: addr }, stats.active)
+            unicorn_queued_connections.set({ socket_type: 'tcp', socket_address: addr }, stats.queued)
           end
 
           Raindrops::Linux.unix_listener_stats(unix_listeners).each do |addr, stats|
-            unicorn_active_connections.set({ type: 'unix', address: addr }, stats.active)
-            unicorn_queued_connections.set({ type: 'unix', address: addr }, stats.queued)
+            unicorn_active_connections.set({ socket_type: 'unix', socket_address: addr }, stats.active)
+            unicorn_queued_connections.set({ socket_type: 'unix', socket_address: addr }, stats.queued)
           end
         end
 

spec/lib/gitlab/metrics/samplers/unicorn_sampler_spec.rb

@@ -37,7 +37,7 @@ describe Gitlab::Metrics::Samplers::UnicornSampler do
         end
 
         it 'updates metrics type unix and with addr' do
-          labels = { type: 'unix', address: socket_address }
+          labels = { socket_type: 'unix', socket_address: socket_address }
 
           expect(subject).to receive_message_chain(:unicorn_active_connections, :set).with(labels, 'active')
           expect(subject).to receive_message_chain(:unicorn_queued_connections, :set).with(labels, 'queued')
@@ -69,7 +69,7 @@ describe Gitlab::Metrics::Samplers::UnicornSampler do
         end
 
         it 'updates metrics type unix and with addr' do
-          labels = { type: 'tcp', address: tcp_socket_address }
+          labels = { socket_type: 'tcp', socket_address: tcp_socket_address }
 
           expect(subject).to receive_message_chain(:unicorn_active_connections, :set).with(labels, 'active')
           expect(subject).to receive_message_chain(:unicorn_queued_connections, :set).with(labels, 'queued')