Merge branch 'sy-update-alert-incident-titles-for-http-integrations' into 'master'

Allow alert incident title to include iid for HTTP integrations

See merge request gitlab-org/gitlab!49274

ee/app/models/ee/issue.rb

@@ -263,7 +263,6 @@ module EE
 
     def generic_alert_with_default_title?
       title == ::Gitlab::AlertManagement::Payload::Generic::DEFAULT_TITLE &&
-        project.alerts_service_activated? &&
         author == ::User.alert_bot
     end
 

ee/changelogs/unreleased/sy-update-alert-incident-titles-for-http-integrations.yml

+---
+title: Include issue iid in default title for untitled incidents when created from
+  alert via HTTP integration
+merge_request: 49274
+author:
+type: fixed

ee/spec/models/issue_spec.rb

@@ -30,30 +30,14 @@ RSpec.describe Issue do
       context 'when issue title is "New: Incident"' do
         let(:issue) { build(:issue, project: project, author: author, title: 'New: Incident', iid: 503503) }
 
-        context 'when alerts service is active' do
-          before do
-            allow(project).to receive(:alerts_service_activated?).and_return(true)
-          end
-
-          context 'when the author is Alert Bot' do
-            it 'updates issue title with the IID' do
-              expect { issue.save }.to change { issue.title }.to("New: Incident 503503")
-            end
-          end
-
-          context 'when the author is not an Alert Bot' do
-            let(:author) { create(:user) }
-
-            it 'does not change issue title' do
-              expect { issue.save }.not_to change { issue.title }
-            end
+        context 'when the author is Alert Bot' do
+          it 'updates issue title with the IID' do
+            expect { issue.save }.to change { issue.title }.to("New: Incident 503503")
           end
         end
 
-        context 'when alerts service is not active' do
-          before do
-            allow(project).to receive(:alerts_service_activated?).and_return(false)
-          end
+        context 'when the author is not an Alert Bot' do
+          let(:author) { create(:user) }
 
           it 'does not change issue title' do
             expect { issue.save }.not_to change { issue.title }