Merge branch...

Merge branch '262466-move-handlers-outside-of-domcontentloaded-app-assets-javascripts-pages-projects' into 'master'

Move handlers outside of DOMContentLoaded for MR List + Show

See merge request gitlab-org/gitlab!45403

app/assets/javascripts/pages/projects/merge_requests/index/index.js

@@ -7,16 +7,15 @@ import IssuableFilteredSearchTokenKeys from '~/filtered_search/issuable_filtered
 import { FILTERED_SEARCH } from '~/pages/constants';
 import { ISSUABLE_INDEX } from '~/pages/projects/constants';
 
-document.addEventListener('DOMContentLoaded', () => {
-  addExtraTokensForMergeRequests(IssuableFilteredSearchTokenKeys);
+new IssuableIndex(ISSUABLE_INDEX.MERGE_REQUEST); // eslint-disable-line no-new
 
-  initFilteredSearch({
-    page: FILTERED_SEARCH.MERGE_REQUESTS,
-    filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
-    useDefaultState: true,
-  });
+addExtraTokensForMergeRequests(IssuableFilteredSearchTokenKeys);
 
-  new IssuableIndex(ISSUABLE_INDEX.MERGE_REQUEST); // eslint-disable-line no-new
-  new ShortcutsNavigation(); // eslint-disable-line no-new
-  new UsersSelect(); // eslint-disable-line no-new
+initFilteredSearch({
+  page: FILTERED_SEARCH.MERGE_REQUESTS,
+  filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
+  useDefaultState: true,
 });
+
+new UsersSelect(); // eslint-disable-line no-new
+new ShortcutsNavigation(); // eslint-disable-line no-new

app/assets/javascripts/pages/projects/merge_requests/show/index.js

@@ -5,12 +5,10 @@ import initShow from '../init_merge_request_show';
 import initIssuableHeaderWarning from '~/vue_shared/components/issuable/init_issuable_header_warning';
 import store from '~/mr_notes/stores';
 
-document.addEventListener('DOMContentLoaded', () => {
-  initShow();
-  if (gon.features && !gon.features.vueIssuableSidebar) {
-    initSidebarBundle();
-  }
-  initMrNotes();
-  initReviewBar();
-  initIssuableHeaderWarning(store);
-});
+initShow();
+if (gon.features && !gon.features.vueIssuableSidebar) {
+  initSidebarBundle();
+}
+initMrNotes();
+initReviewBar();
+initIssuableHeaderWarning(store);

ee/app/assets/javascripts/pages/projects/merge_requests/show/index.js

@@ -6,16 +6,14 @@ import store from '~/mr_notes/stores';
 import initIssuableHeaderWarning from '~/vue_shared/components/issuable/init_issuable_header_warning';
 import initShow from '~/pages/projects/merge_requests/init_merge_request_show';
 
-document.addEventListener('DOMContentLoaded', () => {
-  initShow();
-  if (gon.features && !gon.features.vueIssuableSidebar) {
-    initSidebarBundle();
-  }
-  initMrNotes();
-  initReviewBar();
-  initIssuableHeaderWarning(store);
+initShow();
+if (gon.features && !gon.features.vueIssuableSidebar) {
+  initSidebarBundle();
+}
+initMrNotes();
+initReviewBar();
+initIssuableHeaderWarning(store);
 
-  const assigneeDropdown = document.querySelector('.js-sidebar-assignee-dropdown');
+const assigneeDropdown = document.querySelector('.js-sidebar-assignee-dropdown');
 
-  if (assigneeDropdown) trackShowInviteMemberLink(assigneeDropdown);
-});
+if (assigneeDropdown) trackShowInviteMemberLink(assigneeDropdown);