Merge branch 'ce-to-ee-2018-09-14' into 'master'

CE upstream - 2018-09-14 05:22 UTC

See merge request gitlab-org/gitlab-ee!7369

GITALY_SERVER_VERSION

-0.120.0
+0.121.0

app/finders/access_requests_finder.rb

+# frozen_string_literal: true
+
 class AccessRequestsFinder
   attr_accessor :source
 

app/finders/admin/projects_finder.rb

+# frozen_string_literal: true
+
 class Admin::ProjectsFinder
   attr_reader :params, :current_user
 

app/finders/branches_finder.rb

+# frozen_string_literal: true
+
 class BranchesFinder
   def initialize(repository, params = {})
     @repository = repository

app/finders/clusters_finder.rb

+# frozen_string_literal: true
+
 class ClustersFinder
   def initialize(project, user, scope)
     @project = project

app/finders/concerns/created_at_filter.rb

+# frozen_string_literal: true
+
 module CreatedAtFilter
   def by_created_at(items)
     items = items.created_before(params[:created_before]) if params[:created_before].present?

app/finders/concerns/custom_attributes_filter.rb

+# frozen_string_literal: true
+
 module CustomAttributesFilter
   # rubocop: disable CodeReuse/ActiveRecord
   def by_custom_attributes(items)

app/finders/concerns/finder_methods.rb

+# frozen_string_literal: true
+
 module FinderMethods
   # rubocop: disable CodeReuse/ActiveRecord
   def find_by!(*args)

app/finders/concerns/finder_with_cross_project_access.rb

+# frozen_string_literal: true
+
 # Module to prepend into finders to specify wether or not the finder requires
 # cross project access
 #

app/finders/contributed_projects_finder.rb

+# frozen_string_literal: true
+
 class ContributedProjectsFinder < UnionFinder
   def initialize(user)
     @user = user

app/finders/environments_finder.rb

+# frozen_string_literal: true
+
 class EnvironmentsFinder
   attr_reader :project, :current_user, :params
 

app/finders/events_finder.rb

+# frozen_string_literal: true
+
 class EventsFinder
   prepend FinderMethods
   prepend FinderWithCrossProjectAccess

app/finders/fork_projects_finder.rb

+# frozen_string_literal: true
+
 class ForkProjectsFinder < ProjectsFinder
   # rubocop: disable CodeReuse/ActiveRecord
   def initialize(project, params: {}, current_user: nil)

app/finders/group_descendants_finder.rb

+# frozen_string_literal: true
+
 # GroupDescendantsFinder
 #
 # Used to find and filter all subgroups and projects of a passed parent group

app/finders/group_finder.rb

+# frozen_string_literal: true
+
 class GroupFinder
   include Gitlab::Allowable
 

app/finders/group_members_finder.rb

+# frozen_string_literal: true
+
 class GroupMembersFinder
   def initialize(group)
     @group = group

app/finders/group_projects_finder.rb

+# frozen_string_literal: true
+
 # GroupProjectsFinder
 #
 # Used to filter Projects  by set of params

app/finders/groups_finder.rb

+# frozen_string_literal: true
+
 # GroupsFinder
 #
 # Used to filter Groups by a set of params

app/finders/issuable_finder.rb

+# frozen_string_literal: true
+
 # IssuableFinder
 #
 # Used to filter Issues and MergeRequests collections by set of params

app/finders/issues_finder.rb

+# frozen_string_literal: true
+
 # Finders::Issues class
 #
 # Used to filter Issues collections by set of params

app/finders/joined_groups_finder.rb

+# frozen_string_literal: true
+
 class JoinedGroupsFinder < UnionFinder
   def initialize(user)
     @user = user

app/finders/labels_finder.rb

+# frozen_string_literal: true
+
 class LabelsFinder < UnionFinder
   prepend FinderWithCrossProjectAccess
   include FinderMethods

app/finders/license_template_finder.rb

+# frozen_string_literal: true
+
 # LicenseTemplateFinder
 #
 # Used to find license templates, which may come from a variety of external

app/finders/members_finder.rb

+# frozen_string_literal: true
+
 class MembersFinder
   attr_reader :project, :current_user, :group
 

app/finders/merge_request_target_project_finder.rb

+# frozen_string_literal: true
+
 class MergeRequestTargetProjectFinder
   include FinderMethods
 

app/finders/merge_requests_finder.rb

+# frozen_string_literal: true
+
 # Finders::MergeRequest class
 #
 # Used to filter MergeRequests collections by set of params

app/finders/milestones_finder.rb

+# frozen_string_literal: true
+
 # Search for milestones
 #
 # params - Hash

app/finders/notes_finder.rb

+# frozen_string_literal: true
+
 class NotesFinder
   prepend EE::NotesFinder
 

app/finders/personal_access_tokens_finder.rb

+# frozen_string_literal: true
+
 class PersonalAccessTokensFinder
   attr_accessor :params
 

app/finders/personal_projects_finder.rb

+# frozen_string_literal: true
+
 class PersonalProjectsFinder < UnionFinder
   include Gitlab::Allowable
 

app/finders/pipeline_schedules_finder.rb

+# frozen_string_literal: true
+
 class PipelineSchedulesFinder
   attr_reader :project, :pipeline_schedules
 

app/finders/pipelines_finder.rb

+# frozen_string_literal: true
+
 class PipelinesFinder
   attr_reader :project, :pipelines, :params, :current_user
 

app/finders/projects_finder.rb

+# frozen_string_literal: true
+
 # ProjectsFinder
 #
 # Used to filter Projects  by set of params

app/finders/runner_jobs_finder.rb

+# frozen_string_literal: true
+
 class RunnerJobsFinder
   attr_reader :runner, :params
 

app/finders/snippets_finder.rb

+# frozen_string_literal: true
+
 # Snippets Finder
 #
 # Used to filter Snippets collections by a set of params

app/finders/tags_finder.rb

+# frozen_string_literal: true
+
 class TagsFinder
   def initialize(repository, params)
     @repository = repository

app/finders/template_finder.rb

+# frozen_string_literal: true
+
 class TemplateFinder
   prepend ::EE::TemplateFinder
 

app/finders/todos_finder.rb

+# frozen_string_literal: true
+
 # TodosFinder
 #
 # Used to filter Todos by set of params

app/finders/union_finder.rb

+# frozen_string_literal: true
+
 class UnionFinder
   # rubocop: disable CodeReuse/ActiveRecord
   def find_union(segments, klass)

app/finders/user_recent_events_finder.rb

+# frozen_string_literal: true
+
 # Get user activity feed for projects common for a user and a logged in user
 #
 # - current_user: The user viewing the events

app/finders/users_finder.rb

+# frozen_string_literal: true
+
 # UsersFinder
 #
 # Used to filter users by set of params

app/graphql/functions/base_function.rb

+# frozen_string_literal: true
+
 module Functions
   class BaseFunction < GraphQL::Function
   end

app/graphql/functions/echo.rb

+# frozen_string_literal: true
+
 module Functions
   class Echo < BaseFunction
     argument :text, GraphQL::STRING_TYPE

app/graphql/gitlab_schema.rb

+# frozen_string_literal: true
+
 class GitlabSchema < GraphQL::Schema
   use BatchLoader::GraphQL
   use Gitlab::Graphql::Authorize

app/graphql/mutations/concerns/mutations/resolves_project.rb

+# frozen_string_literal: true
+
 module Mutations
   module ResolvesProject
     extend ActiveSupport::Concern

app/graphql/mutations/merge_requests/base.rb

+# frozen_string_literal: true
+
 module Mutations
   module MergeRequests
     class Base < BaseMutation

app/graphql/resolvers/base_resolver.rb

+# frozen_string_literal: true
+
 module Resolvers
   class BaseResolver < GraphQL::Schema::Resolver
   end

app/graphql/resolvers/concerns/resolves_pipelines.rb

+# frozen_string_literal: true
+
 module ResolvesPipelines
   extend ActiveSupport::Concern
 

app/graphql/resolvers/full_path_resolver.rb

+# frozen_string_literal: true
+
 module Resolvers
   module FullPathResolver
     extend ActiveSupport::Concern

app/graphql/resolvers/merge_request_pipelines_resolver.rb

+# frozen_string_literal: true
+
 module Resolvers
   class MergeRequestPipelinesResolver < BaseResolver
     include ::ResolvesPipelines

app/graphql/resolvers/merge_request_resolver.rb

+# frozen_string_literal: true
+
 module Resolvers
   class MergeRequestResolver < BaseResolver
     argument :iid, GraphQL::ID_TYPE,

app/graphql/resolvers/project_pipelines_resolver.rb

+# frozen_string_literal: true
+
 module Resolvers
   class ProjectPipelinesResolver < BaseResolver
     include ResolvesPipelines

app/graphql/resolvers/project_resolver.rb

+# frozen_string_literal: true
+
 module Resolvers
   class ProjectResolver < BaseResolver
     prepend FullPathResolver

app/graphql/types/base_enum.rb

+# frozen_string_literal: true
+
 module Types
   class BaseEnum < GraphQL::Schema::Enum
   end

app/graphql/types/base_field.rb

+# frozen_string_literal: true
+
 module Types
   class BaseField < GraphQL::Schema::Field
     prepend Gitlab::Graphql::Authorize

app/graphql/types/base_input_object.rb

+# frozen_string_literal: true
+
 module Types
   class BaseInputObject < GraphQL::Schema::InputObject
   end

app/graphql/types/base_interface.rb

+# frozen_string_literal: true
+
 module Types
   module BaseInterface
     include GraphQL::Schema::Interface

app/graphql/types/base_object.rb

+# frozen_string_literal: true
+
 module Types
   class BaseObject < GraphQL::Schema::Object
     prepend Gitlab::Graphql::Present

app/graphql/types/base_scalar.rb

+# frozen_string_literal: true
+
 module Types
   class BaseScalar < GraphQL::Schema::Scalar
   end

app/graphql/types/base_union.rb

+# frozen_string_literal: true
+
 module Types
   class BaseUnion < GraphQL::Schema::Union
   end

app/graphql/types/ci/pipeline_status_enum.rb

+# frozen_string_literal: true
+
 module Types
   module Ci
     class PipelineStatusEnum < BaseEnum

app/graphql/types/ci/pipeline_type.rb

+# frozen_string_literal: true
+
 module Types
   module Ci
     class PipelineType < BaseObject

app/graphql/types/merge_request_type.rb

+# frozen_string_literal: true
+
 module Types
   class MergeRequestType < BaseObject
     expose_permissions Types::PermissionTypes::MergeRequest

app/graphql/types/permission_types/base_permission_type.rb

+# frozen_string_literal: true
+
 module Types
   module PermissionTypes
     class BasePermissionType < BaseObject

app/graphql/types/permission_types/ci/pipeline.rb

+# frozen_string_literal: true
+
 module Types
   module PermissionTypes
     module Ci

app/graphql/types/permission_types/merge_request.rb

+# frozen_string_literal: true
+
 module Types
   module PermissionTypes
     class MergeRequest < BasePermissionType

app/graphql/types/permission_types/project.rb

+# frozen_string_literal: true
+
 module Types
   module PermissionTypes
     class Project < BasePermissionType

app/graphql/types/project_type.rb

+# frozen_string_literal: true
+
 module Types
   class ProjectType < BaseObject
     expose_permissions Types::PermissionTypes::Project

app/graphql/types/query_type.rb

+# frozen_string_literal: true
+
 module Types
   class QueryType < BaseObject
     graphql_name 'Query'

app/graphql/types/time_type.rb

+# frozen_string_literal: true
+
 module Types
   class TimeType < BaseScalar
     graphql_name 'Time'

changelogs/unreleased/frozen-string-app-finders-graphql.yml

+---
+title: Enable frozen string in app/graphql + app/finders
+merge_request:
+author: gfyoung
+type: performance

spec/lib/gitlab/git/repository_spec.rb

@@ -1752,7 +1752,7 @@ describe Gitlab::Git::Repository, :seed_helper do
 
   describe '#checksum' do
     it 'calculates the checksum for non-empty repo' do
-      expect(repository.checksum).to eq '4be7d24ce7e8d845502d599b72d567d23e6a40c0'
+      expect(repository.checksum).to eq '51d0a9662681f93e1fee547a6b7ba2bcaf716059'
     end
 
     it 'returns 0000000000000000000000000000000000000000 for an empty repo' do