Merge branch 'fix-delegator_override_with-for-strong-memoize' into 'master'

Fix the comment for StrongMemoize inclusion in presenters

See merge request gitlab-org/gitlab!80777

app/presenters/README.md

@@ -223,13 +223,9 @@ To add methods of a module to an allowlist, use `delegator_override_with`. For e
 ```ruby
 module Ci
   class PipelinePresenter < Gitlab::View::Presenter::Delegated
-    include Gitlab::Utils::StrongMemoize
-    include ActionView::Helpers::UrlHelper
+    include ActionView::Helpers::TagHelper
 
-    delegator_override_with Gitlab::Utils::StrongMemoize # TODO: Remove `Gitlab::Utils::StrongMemoize` inclusion as it's duplicate
-    delegator_override_with ActionView::Helpers::TagHelper # TODO: Remove `ActionView::Helpers::UrlHelper` inclusion as it overrides `Ci::Pipeline#tag`
+    delegator_override_with ActionView::Helpers::TagHelper # TODO: Remove `ActionView::Helpers::TagHelper` inclusion as it overrides `Ci::Pipeline#tag`
 ```
 
-Keep in mind that if you use `delegator_override_with`,
-there is a high chance that you're doing **something wrong**.
 Read the [Validate Accidental Overrides](#validate-accidental-overrides) for more information.

app/presenters/alert_management/alert_presenter.rb

@@ -6,7 +6,7 @@ module AlertManagement
     include ActionView::Helpers::UrlHelper
 
     presents ::AlertManagement::Alert
-    delegator_override_with Gitlab::Utils::StrongMemoize # TODO: Remove `Gitlab::Utils::StrongMemoize` inclusion as it's duplicate
+    delegator_override_with Gitlab::Utils::StrongMemoize # This module inclusion is expected. See https://gitlab.com/gitlab-org/gitlab/-/issues/352884.
 
     MARKDOWN_LINE_BREAK = "  \n"
     HORIZONTAL_LINE = "\n\n---\n\n"

app/presenters/ci/pipeline_presenter.rb

@@ -4,7 +4,7 @@ module Ci
   class PipelinePresenter < Gitlab::View::Presenter::Delegated
     include Gitlab::Utils::StrongMemoize
 
-    delegator_override_with Gitlab::Utils::StrongMemoize # TODO: Remove `Gitlab::Utils::StrongMemoize` inclusion as it's duplicate
+    delegator_override_with Gitlab::Utils::StrongMemoize # This module inclusion is expected. See https://gitlab.com/gitlab-org/gitlab/-/issues/352884.
     delegator_override_with ActionView::Helpers::TagHelper # TODO: Remove `ActionView::Helpers::UrlHelper` inclusion as it overrides `Ci::Pipeline#tag`
 
     # We use a class method here instead of a constant, allowing EE to redefine

app/presenters/project_presenter.rb

@@ -13,7 +13,7 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
   include Gitlab::Experiment::Dsl
 
   delegator_override_with GitlabRoutingHelper # TODO: Remove `GitlabRoutingHelper` inclusion as it's duplicate
-  delegator_override_with Gitlab::Utils::StrongMemoize # TODO: Remove `Gitlab::Utils::StrongMemoize` inclusion as it's duplicate
+  delegator_override_with Gitlab::Utils::StrongMemoize # This module inclusion is expected. See https://gitlab.com/gitlab-org/gitlab/-/issues/352884.
 
   presents ::Project, as: :project