Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7cd20b91
Commit
7cd20b91
authored
May 13, 2020
by
Doug Stull
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow developers to see ci minutes notifications
- we want to broaden the audience as much as we can.
parent
6a67fe97
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
9 additions
and
4 deletions
+9
-4
ee/app/policies/ee/group_policy.rb
ee/app/policies/ee/group_policy.rb
+1
-1
ee/changelogs/unreleased/217469-follow-up-from-fix-minutes-notification-when-unauthenticated.yml
...up-from-fix-minutes-notification-when-unauthenticated.yml
+5
-0
ee/spec/models/ci/minutes/context_spec.rb
ee/spec/models/ci/minutes/context_spec.rb
+1
-1
ee/spec/models/ci/minutes/notification_spec.rb
ee/spec/models/ci/minutes/notification_spec.rb
+1
-1
ee/spec/policies/group_policy_spec.rb
ee/spec/policies/group_policy_spec.rb
+1
-1
No files found.
ee/app/policies/ee/group_policy.rb
View file @
7cd20b91
...
...
@@ -91,7 +91,6 @@ module EE
enable
:create_jira_connect_subscription
enable
:maintainer_access
enable
:admin_wiki
enable
:read_ci_minutes_quota
end
rule
{
owner
}.
policy
do
...
...
@@ -174,6 +173,7 @@ module EE
rule
{
developer
}.
policy
do
enable
:create_wiki
enable
:admin_merge_request
enable
:read_ci_minutes_quota
end
rule
{
security_dashboard_enabled
&
developer
}.
enable
:read_group_security_dashboard
...
...
ee/changelogs/unreleased/217469-follow-up-from-fix-minutes-notification-when-unauthenticated.yml
0 → 100644
View file @
7cd20b91
---
title
:
Allow developers to see ci minutes notifications
merge_request
:
31937
author
:
type
:
changed
ee/spec/models/ci/minutes/context_spec.rb
View file @
7cd20b91
...
...
@@ -53,7 +53,7 @@ describe Ci::Minutes::Context do
describe
'#can_see_status'
do
context
'when eligible to see status'
do
before
do
group
.
add_
own
er
(
user
)
group
.
add_
develop
er
(
user
)
end
it
'can see status'
do
...
...
ee/spec/models/ci/minutes/notification_spec.rb
View file @
7cd20b91
...
...
@@ -128,7 +128,7 @@ describe Ci::Minutes::Notification do
describe
'#show?'
do
context
'when eligible to see notifications'
do
before
do
group
.
add_
own
er
(
user
)
group
.
add_
develop
er
(
user
)
end
context
'with a project that has runners enabled inside namespace'
do
...
...
ee/spec/policies/group_policy_spec.rb
View file @
7cd20b91
...
...
@@ -885,7 +885,7 @@ describe GroupPolicy do
where
(
:role
,
:allowed
)
do
:guest
|
false
:reporter
|
false
:developer
|
fals
e
:developer
|
tru
e
:maintainer
|
true
:owner
|
true
:admin
|
true
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment