Merge branch 'leaky-constant-fix-26' into 'master'

Fix leaky constant in factory spec

See merge request gitlab-org/gitlab!32099

.rubocop.yml

@@ -367,7 +367,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
     - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb'
     - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
-    - 'spec/lib/gitlab/view/presenter/factory_spec.rb'
     - 'spec/lib/marginalia_spec.rb'
     - 'spec/mailers/notify_spec.rb'
     - 'spec/migrations/20191125114345_add_admin_mode_protected_path_spec.rb'

changelogs/unreleased/leaky-constant-fix-26.yml

+---
+title: Fix leaky constant issue in factory spec
+merge_request: 32099
+author: Rajendra Kadam
+type: fixed

spec/lib/gitlab/view/presenter/factory_spec.rb

@@ -31,11 +31,11 @@ describe Gitlab::View::Presenter::Factory do
     end
 
     it 'uses the presenter_class if given on #initialize' do
-      MyCustomPresenter = Class.new(described_class)
+      my_custom_presenter = Class.new(described_class)
 
-      presenter = described_class.new(build, presenter_class: MyCustomPresenter).fabricate!
+      presenter = described_class.new(build, presenter_class: my_custom_presenter).fabricate!
 
-      expect(presenter).to be_a(MyCustomPresenter)
+      expect(presenter).to be_a(my_custom_presenter)
     end
   end
 end