Moved the http call into the service

app/assets/javascripts/boards/components/board_new_form.js

@@ -58,13 +58,7 @@ const boardMilestoneSelect = require('./milestone_select');
     methods: {
       loadMilestones() {
         this.milestoneDropdownOpen = !this.milestoneDropdownOpen;
-
-        if (!this.milestones.length) {
-          this.$http.get(this.milestonePath)
-            .then((res) => {
-              this.milestones = res.json();
-            });
-        }
+        BoardService.loadMilestones.call(this);
       },
       submit() {
         gl.boardService.createBoard(this.board)

app/assets/javascripts/boards/components/milestone_select.js

@@ -18,19 +18,14 @@ module.exports = Vue.extend({
     return {
       loading: false,
       milestones: [],
-      anyMilestone: {
+      extraMilestones: [{
         id: null,
         title: 'Any Milestone',
-      },
+      }],
     };
   },
   mounted() {
-    this.loading = true;
-    this.$http.get(this.milestonePath)
-      .then((res) => {
-        this.milestones = res.json();
-        this.loading = false;
-      });
+    BoardService.loadMilestones.call(this);
   },
   template: `
     <div>
@@ -42,14 +37,14 @@ module.exports = Vue.extend({
       <ul
         class="board-milestone-list"
         v-if="!loading">
-        <li>
+        <li v-for="milestone in extraMilestones">
           <a
             href="#"
-            @click.prevent.stop="selectMilestone(anyMilestone)">
+            @click.prevent.stop="selectMilestone(milestone)">
             <i
               class="fa fa-check"
-              v-if="board.milestone_id === anyMilestone.id"></i>
-            {{ anyMilestone.title }}
+              v-if="board.milestone_id === milestone.id"></i>
+            {{ milestone.title }}
           </a>
         </li>
         <li class="divider"></li>

app/assets/javascripts/boards/services/board_service.js

@@ -102,6 +102,16 @@ class BoardService {
 
     return this.issues.bulkUpdate(data);
   }
+
+  static loadMilestones(path) {
+    this.loading = true;
+
+    return this.$http.get(this.milestonePath)
+      .then((res) => {
+        this.milestones = res.json();
+        this.loading = false;
+      });
+  }
 }
 
 window.BoardService = BoardService;