Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
810cbc51
Commit
810cbc51
authored
Dec 04, 2021
by
Siddharth Asthana
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Gitlab/DelegatePredicateMethods offenses
Changelog: other
parent
70a1dc76
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
2 deletions
+4
-2
.rubocop_todo/gitlab/delegate_predicate_methods.yml
.rubocop_todo/gitlab/delegate_predicate_methods.yml
+0
-1
app/models/concerns/resolvable_discussion.rb
app/models/concerns/resolvable_discussion.rb
+4
-1
No files found.
.rubocop_todo/gitlab/delegate_predicate_methods.yml
View file @
810cbc51
...
...
@@ -6,7 +6,6 @@ Gitlab/DelegatePredicateMethods:
-
app/models/concerns/ci/metadatable.rb
-
app/models/concerns/diff_positionable_note.rb
-
app/models/concerns/integrations/base_data_fields.rb
-
app/models/concerns/resolvable_discussion.rb
-
app/models/project.rb
-
ee/app/models/concerns/ee/ci/metadatable.rb
-
ee/app/models/ee/group.rb
...
...
app/models/concerns/resolvable_discussion.rb
View file @
810cbc51
...
...
@@ -30,11 +30,14 @@ module ResolvableDiscussion
delegate
:resolved_at
,
:resolved_by
,
:resolved_by_push?
,
to: :last_resolved_note
,
allow_nil:
true
end
def
resolved_by_push?
!!
last_resolved_note
&
.
resolved_by_push?
end
def
resolvable?
strong_memoize
(
:resolvable
)
do
potentially_resolvable?
&&
notes
.
any?
(
&
:resolvable?
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment