Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
81e0695a
Commit
81e0695a
authored
Sep 03, 2020
by
Rajendra Kadam
Committed by
Rémy Coutable
Sep 03, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Rails/SaveBang offenses for spec/requests/api/pages/*
Fixes Rails/SaveBang cop for spec files
parent
e2e3b618
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
6 deletions
+8
-6
.rubocop_todo.yml
.rubocop_todo.yml
+0
-3
changelogs/unreleased/rails-save-bang-22.yml
changelogs/unreleased/rails-save-bang-22.yml
+5
-0
spec/requests/api/pages/internal_access_spec.rb
spec/requests/api/pages/internal_access_spec.rb
+1
-1
spec/requests/api/pages/private_access_spec.rb
spec/requests/api/pages/private_access_spec.rb
+1
-1
spec/requests/api/pages/public_access_spec.rb
spec/requests/api/pages/public_access_spec.rb
+1
-1
No files found.
.rubocop_todo.yml
View file @
81e0695a
...
...
@@ -1196,9 +1196,6 @@ Rails/SaveBang:
-
'
spec/requests/api/merge_request_diffs_spec.rb'
-
'
spec/requests/api/merge_requests_spec.rb'
-
'
spec/requests/api/notes_spec.rb'
-
'
spec/requests/api/pages/internal_access_spec.rb'
-
'
spec/requests/api/pages/private_access_spec.rb'
-
'
spec/requests/api/pages/public_access_spec.rb'
-
'
spec/requests/api/pipeline_schedules_spec.rb'
-
'
spec/requests/api/project_import_spec.rb'
-
'
spec/requests/api/project_milestones_spec.rb'
...
...
changelogs/unreleased/rails-save-bang-22.yml
0 → 100644
View file @
81e0695a
---
title
:
Fix Rails/SaveBang offenses for spec/requests/api/pages/*
merge_request
:
41324
author
:
type
:
fixed
spec/requests/api/pages/internal_access_spec.rb
View file @
81e0695a
...
...
@@ -72,7 +72,7 @@ RSpec.describe "Internal Project Pages Access" do
with_them
do
before
do
project
.
project_feature
.
update
(
pages_access_level:
pages_access_level
)
project
.
project_feature
.
update
!
(
pages_access_level:
pages_access_level
)
end
it
"correct return value"
do
if
!
with_user
.
nil?
...
...
spec/requests/api/pages/private_access_spec.rb
View file @
81e0695a
...
...
@@ -72,7 +72,7 @@ RSpec.describe "Private Project Pages Access" do
with_them
do
before
do
project
.
project_feature
.
update
(
pages_access_level:
pages_access_level
)
project
.
project_feature
.
update
!
(
pages_access_level:
pages_access_level
)
end
it
"correct return value"
do
if
!
with_user
.
nil?
...
...
spec/requests/api/pages/public_access_spec.rb
View file @
81e0695a
...
...
@@ -72,7 +72,7 @@ RSpec.describe "Public Project Pages Access" do
with_them
do
before
do
project
.
project_feature
.
update
(
pages_access_level:
pages_access_level
)
project
.
project_feature
.
update
!
(
pages_access_level:
pages_access_level
)
end
it
"correct return value"
do
if
!
with_user
.
nil?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment