Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
822534c4
Commit
822534c4
authored
Dec 21, 2016
by
Sam Rose
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace link to Resolve conflicts with buttons
Use variables for display logic conditional checks
parent
0dcbd4c7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
14 deletions
+20
-14
app/views/projects/merge_requests/widget/open/_conflicts.html.haml
.../projects/merge_requests/widget/open/_conflicts.html.haml
+16
-14
changelogs/unreleased/21135-resolve-these-conflicts-link-is-too-subtle.yml
...ased/21135-resolve-these-conflicts-link-is-too-subtle.yml
+4
-0
No files found.
app/views/projects/merge_requests/widget/open/_conflicts.html.haml
View file @
822534c4
-
can_resolve
=
@merge_request
.
conflicts_can_be_resolved_by?
(
current_user
)
-
can_resolve_in_ui
=
@merge_request
.
conflicts_can_be_resolved_in_ui?
-
can_merge
=
@merge_request
.
can_be_merged_via_command_line_by?
(
current_user
)
%h4
.has-conflicts
=
icon
(
"exclamation-triangle"
)
This merge request contains merge conflicts
%p
Please
-
if
@merge_request
.
conflicts_can_be_resolved_by?
(
current_user
)
-
if
@merge_request
.
conflicts_can_be_resolved_in_ui?
=
link_to
"resolve these conflicts"
,
conflicts_namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
)
-
else
%span
.has-tooltip
{
title:
"These conflicts cannot be resolved through GitLab"
}
resolve these conflicts locally
-
else
resolve these conflicts
To merge this request, resolve these conflicts
-
if
can_resolve
&&
!
can_resolve_in_ui
locally
or
-
unless
can_merge
ask someone with write access to this repository to
merge it locally.
-
if
@merge_request
.
can_be_merged_via_command_line_by?
(
current_user
)
#{
link_to
"merge this request manually"
,
"#modal_merge_info"
,
class:
"how_to_merge_link vlink"
,
"data-toggle"
=>
"modal"
}
.
-
else
ask someone with write access to this repository to merge this request manually.
-
if
(
can_resolve
&&
can_resolve_in_ui
)
||
can_merge
.btn-group
-
if
can_resolve
&&
can_resolve_in_ui
=
link_to
"Resolve conflicts"
,
conflicts_namespace_project_merge_request_path
(
@project
.
namespace
,
@project
,
@merge_request
),
class:
"btn"
-
if
can_merge
=
link_to
"Merge locally"
,
"#modal_merge_info"
,
class:
"btn how_to_merge_link vlink"
,
"data-toggle"
=>
"modal"
changelogs/unreleased/21135-resolve-these-conflicts-link-is-too-subtle.yml
0 → 100644
View file @
822534c4
---
title
:
Improve visibility of "Resolve conflicts" and "Merge locally" actions
merge_request
:
8229
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment