Commit 824d01b7 authored by Oswaldo Ferreira's avatar Oswaldo Ferreira

Remove unnecessary bang from methods

parent d499d228
...@@ -9,7 +9,7 @@ module RelatedIssues ...@@ -9,7 +9,7 @@ module RelatedIssues
return error('No Issue found for given reference', 401) return error('No Issue found for given reference', 401)
end end
create_related_issues! create_related_issues
success_message success_message
rescue => exception rescue => exception
...@@ -18,20 +18,20 @@ module RelatedIssues ...@@ -18,20 +18,20 @@ module RelatedIssues
private private
def create_related_issues! def create_related_issues
RelatedIssue.transaction do RelatedIssue.transaction do
referenced_issues.each do |referenced_issue| referenced_issues.each do |referenced_issue|
relate_issues!(referenced_issue) relate_issues(referenced_issue)
create_notes!(referenced_issue) create_notes(referenced_issue)
end end
end end
end end
def relate_issues!(referenced_issue) def relate_issues(referenced_issue)
RelatedIssue.create!(issue: @issue, related_issue: referenced_issue) RelatedIssue.create!(issue: @issue, related_issue: referenced_issue)
end end
def create_notes!(referenced_issue) def create_notes(referenced_issue)
SystemNoteService.relate_issue(@issue, referenced_issue, current_user) SystemNoteService.relate_issue(@issue, referenced_issue, current_user)
SystemNoteService.relate_issue(referenced_issue, @issue, current_user) SystemNoteService.relate_issue(referenced_issue, @issue, current_user)
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment