Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
82be3938
Commit
82be3938
authored
Mar 30, 2021
by
Huzaifa Iftikhar
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Rails/SaveBang Rubocop offenses for presenters
parent
fffdd5c4
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
7 deletions
+4
-7
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-3
spec/presenters/ci/build_runner_presenter_spec.rb
spec/presenters/ci/build_runner_presenter_spec.rb
+2
-2
spec/presenters/ci/trigger_presenter_spec.rb
spec/presenters/ci/trigger_presenter_spec.rb
+1
-1
spec/presenters/packages/conan/package_presenter_spec.rb
spec/presenters/packages/conan/package_presenter_spec.rb
+1
-1
No files found.
.rubocop_manual_todo.yml
View file @
82be3938
...
...
@@ -388,9 +388,6 @@ Rails/SaveBang:
-
'
spec/models/user_status_spec.rb'
-
'
spec/models/wiki_page/meta_spec.rb'
-
'
spec/models/wiki_page_spec.rb'
-
'
spec/presenters/ci/build_runner_presenter_spec.rb'
-
'
spec/presenters/ci/trigger_presenter_spec.rb'
-
'
spec/presenters/packages/conan/package_presenter_spec.rb'
-
'
spec/requests/api/ci/runner_spec.rb'
-
'
spec/requests/api/commit_statuses_spec.rb'
-
'
spec/requests/api/conan_packages_spec.rb'
...
...
spec/presenters/ci/build_runner_presenter_spec.rb
View file @
82be3938
...
...
@@ -223,7 +223,7 @@ RSpec.describe Ci::BuildRunnerPresenter do
let
(
:build
)
{
create
(
:ci_build
,
ref:
pipeline
.
ref
,
pipeline:
pipeline
)
}
before
do
pipeline
.
persistent_ref
.
create
pipeline
.
persistent_ref
.
create
# rubocop:disable Rails/SaveBang
end
it
'returns the correct refspecs'
do
...
...
@@ -261,7 +261,7 @@ RSpec.describe Ci::BuildRunnerPresenter do
let
(
:build
)
{
create
(
:ci_build
,
pipeline:
pipeline
)
}
before
do
pipeline
.
persistent_ref
.
create
pipeline
.
persistent_ref
.
create
# rubocop:disable Rails/SaveBang
end
it
'exposes the persistent pipeline ref'
do
...
...
spec/presenters/ci/trigger_presenter_spec.rb
View file @
82be3938
...
...
@@ -35,7 +35,7 @@ RSpec.describe Ci::TriggerPresenter do
context
'when user is a trigger owner and builds admin'
do
before
do
trigger
.
update
(
owner:
user
)
trigger
.
update
!
(
owner:
user
)
end
describe
'#token'
do
...
...
spec/presenters/packages/conan/package_presenter_spec.rb
View file @
82be3938
...
...
@@ -146,7 +146,7 @@ RSpec.describe ::Packages::Conan::PackagePresenter do
before
do
[
info_file
,
manifest_file
,
package_file
].
each
do
|
file
|
file
.
conan_file_metadatum
.
conan_package_reference
=
alternative_reference
file
.
save
file
.
save
!
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment