Add sign-in count to external pipeline validation

This will add another data point for distinguishing old accounts
vs. accounts that haven't been used very often.

Changelog: added

doc/administration/external_pipeline_validation.md

@@ -76,7 +76,8 @@ required number of seconds.
         "email": { "type": "string" },
         "created_at": { "type": ["string", "null"], "format": "date-time" },
         "current_sign_in_ip": { "type": ["string", "null"] },
-        "last_sign_in_ip": { "type": ["string", "null"] }
+        "last_sign_in_ip": { "type": ["string", "null"] },
+        "sign_in_count": { "type": "integer" }
       }
     },
     "pipeline": {

lib/gitlab/ci/pipeline/chain/validate/external.rb

@@ -91,7 +91,9 @@ module Gitlab
                   email: current_user.email,
                   created_at: current_user.created_at&.iso8601,
                   current_sign_in_ip: current_user.current_sign_in_ip,
-                  last_sign_in_ip: current_user.last_sign_in_ip
+                  last_sign_in_ip: current_user.last_sign_in_ip,
+                  sign_in_count: current_user.sign_in_count
+
                 },
                 pipeline: {
                   sha: pipeline.sha,

spec/fixtures/api/schemas/external_validation.json

@@ -34,7 +34,8 @@
         "email": { "type": "string" },
         "created_at": { "type": ["string", "null"], "format": "date-time" },
         "current_sign_in_ip": { "type": ["string", "null"] },
-        "last_sign_in_ip": { "type": ["string", "null"] }
+        "last_sign_in_ip": { "type": ["string", "null"] },
+        "sign_in_count": { "type": "integer" }
       }
     },
     "pipeline": {