Merge branch 'standardize-description-of-qa-tests-from-the-plan-stage' into 'master'

Standardize QA tests' descriptions of the DevOps Plan stage

See merge request gitlab-org/gitlab!24621

qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Plan', :reliable do
     describe 'check xss occurence in @mentions in issues', :requires_admin do
-      it 'user mentions a user in comment' do
+      it 'mentions a user in a comment' do
         QA::Runtime::Env.personal_access_token = QA::Runtime::Env.admin_personal_access_token
 
         unless QA::Runtime::Env.personal_access_token

qa/qa/specs/features/browser_ui/2_plan/issue/close_issue_spec.rb

@@ -18,7 +18,7 @@ module QA
         push_commit('Initial commit')
       end
 
-      it 'user closes an issue by pushing commit' do
+      it 'closes an issue by pushing a commit' do
         push_commit("Closes ##{issue_id}", false)
 
         issue.visit!

qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb

@@ -17,7 +17,7 @@ module QA
         end
       end
 
-      it 'user collapses and expands reply for comments in an issue' do
+      it 'collapses and expands reply for comments in an issue' do
         Page::Project::Issue::Show.perform do |show|
           one_reply = "1 reply"
 

qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb

@@ -9,7 +9,7 @@ module QA
         Resource::Issue.fabricate_via_api!.visit!
       end
 
-      it 'user comments on an issue and edits the comment' do
+      it 'comments on an issue and edits the comment' do
         Page::Project::Issue::Show.perform do |show|
           first_version_of_comment = 'First version of the comment'
           second_version_of_comment = 'Second version of the comment'

qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb

@@ -7,7 +7,7 @@ module QA
         Flow::Login.sign_in
       end
 
-      it 'user creates an issue' do
+      it 'creates an issue' do
         issue = Resource::Issue.fabricate_via_browser_ui!
 
         Page::Project::Menu.perform(&:click_issues)
@@ -27,7 +27,7 @@ module QA
           Resource::Issue.fabricate_via_api!.visit!
         end
 
-        it 'user comments on an issue with an attachment' do
+        it 'comments on an issue with an attachment' do
           Page::Project::Issue::Show.perform do |show|
             show.comment('See attached banana for scale', attachment: file_to_attach)
 

qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb

@@ -9,7 +9,7 @@ module QA
         Resource::Issue.fabricate_via_api!.visit!
       end
 
-      it 'user filters comments and activities in an issue' do
+      it 'filters comments and activities in an issue' do
         Page::Project::Issue::Show.perform do |show|
           my_own_comment = "My own comment"
           made_the_issue_confidential = "made the issue confidential"

qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb

@@ -13,7 +13,7 @@ module QA
         end.project.visit!
       end
 
-      it 'user sees issue suggestions when creating a new issue' do
+      it 'shows issue suggestions when creating a new issue' do
         Page::Project::Show.perform(&:go_to_new_issue)
         Page::Project::Issue::New.perform do |new_page|
           new_page.add_title("issue")

qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb

@@ -20,7 +20,7 @@ module QA
         end.visit!
       end
 
-      it 'user mentions another user in an issue' do
+      it 'mentions another user in an issue' do
         Page::Project::Issue::Show.perform do |show|
           at_username = "@#{@user.username}"
 

qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb

@@ -13,7 +13,7 @@ module QA
         @fixed_due_date = (Date.today.to_date + 90).strftime("%Y-%m-%d")
       end
 
-      it 'Updating milestones changes epic dates' do
+      it 'changes epic dates when updating milestones' do
         epic_iid, milestone_id = create_epic_issue_milestone
         milestone_start_date = Date.today.to_date.strftime("%Y-%m-%d")
         milestone_due_date = (Date.today.to_date + 30).strftime("%Y-%m-%d")
@@ -34,7 +34,7 @@ module QA
         expect_json('due_date', milestone_due_date)
       end
 
-      it 'Adding another issue updates epic dates' do
+      it 'updates epic dates when adding another issue' do
         epic_iid = create_epic_issue_milestone[0]
         milestone_start_date = Date.today.to_date.strftime("%Y-%m-%d")
         milestone_due_date = (Date.today.to_date + 150).strftime("%Y-%m-%d")
@@ -57,7 +57,7 @@ module QA
         expect_json('due_date', milestone_due_date)
       end
 
-      it 'Removing issue updates epic dates' do
+      it 'updates epic dates when removing issue' do
         epic_iid = create_epic_issue_milestone[0]
 
         # Get epic_issue_id
@@ -82,7 +82,7 @@ module QA
         expect_json('due_date', nil)
       end
 
-      it 'Deleting milestones updates epic dates' do
+      it 'updates epic dates when deleting milestones' do
         epic_iid, milestone_id = create_epic_issue_milestone
 
         # Delete Milestone

qa/qa/specs/features/ee/browser_ui/2_plan/epic/promote_issue_to_epic_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Plan', :reliable do
     describe 'promote issue to epic' do
-      it 'user promotes issue to an epic' do
+      it 'promotes issue to epic' do
         Flow::Login.sign_in
 
         project = Resource::Project.fabricate_via_api! do |project|