Merge branch 'ab/blacklist-add-column-with-default' into 'master'

Blacklist tables for add_column_with_default

See merge request gitlab-org/gitlab!25882

db/migrate/20180305144721_add_privileged_to_runner.rb

@@ -9,7 +9,7 @@ class AddPrivilegedToRunner < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :clusters_applications_runners, :privileged, :boolean, default: true, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :clusters_applications_runners, :privileged, :boolean, default: true, allow_null: false
   end
 
   def down

db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb

@@ -5,7 +5,7 @@ class AddPagesAccessLevelToProjectFeature < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
-    add_column_with_default(:project_features, :pages_access_level, :integer, default: ProjectFeature::PUBLIC, allow_null: false) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:project_features, :pages_access_level, :integer, default: ProjectFeature::PUBLIC, allow_null: false)
 
     change_column_default(:project_features, :pages_access_level, ProjectFeature::ENABLED)
   end

db/migrate/20180529093006_ensure_remote_mirror_columns.rb

@@ -11,7 +11,7 @@ class EnsureRemoteMirrorColumns < ActiveRecord::Migration[4.2]
     add_column :remote_mirrors, :remote_name, :string unless column_exists?(:remote_mirrors, :remote_name) # rubocop:disable Migration/AddLimitToStringColumns
 
     unless column_exists?(:remote_mirrors, :only_protected_branches)
-      add_column_with_default(:remote_mirrors, # rubocop:disable Migration/AddColumnWithDefault
+      add_column_with_default(:remote_mirrors,
                               :only_protected_branches,
                               :boolean,
                               default: false,

db/migrate/20180601213245_add_deploy_strategy_to_project_auto_devops.rb

@@ -10,7 +10,7 @@ class AddDeployStrategyToProjectAutoDevops < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :project_auto_devops, :deploy_strategy, :integer, default: 0, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :project_auto_devops, :deploy_strategy, :integer, default: 0, allow_null: false
   end
 
   def down

db/migrate/20180831164905_add_common_to_prometheus_metrics.rb

@@ -8,7 +8,7 @@ class AddCommonToPrometheusMetrics < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:prometheus_metrics, :common, :boolean, default: false) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:prometheus_metrics, :common, :boolean, default: false)
   end
 
   def down

db/migrate/20180907015926_add_legacy_abac_to_cluster_providers_gcp.rb

@@ -8,7 +8,7 @@ class AddLegacyAbacToClusterProvidersGcp < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:cluster_providers_gcp, :legacy_abac, :boolean, default: true) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:cluster_providers_gcp, :legacy_abac, :boolean, default: true)
   end
 
   def down

db/migrate/20181017001059_add_cluster_type_to_clusters.rb

@@ -9,7 +9,7 @@ class AddClusterTypeToClusters < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:clusters, :cluster_type, :smallint, default: PROJECT_CLUSTER_TYPE) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:clusters, :cluster_type, :smallint, default: PROJECT_CLUSTER_TYPE)
   end
 
   def down

db/migrate/20190218134158_add_masked_to_ci_variables.rb

@@ -12,7 +12,7 @@ class AddMaskedToCiVariables < ActiveRecord::Migration[5.0]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :ci_variables, :masked, :boolean, default: false, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :ci_variables, :masked, :boolean, default: false, allow_null: false
   end
 
   def down

db/migrate/20190218134209_add_masked_to_ci_group_variables.rb

@@ -12,7 +12,7 @@ class AddMaskedToCiGroupVariables < ActiveRecord::Migration[5.0]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :ci_group_variables, :masked, :boolean, default: false, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :ci_group_variables, :masked, :boolean, default: false, allow_null: false
   end
 
   def down

db/migrate/20190220142344_add_email_header_and_footer_enabled_flag_to_appearances_table.rb

@@ -8,7 +8,7 @@ class AddEmailHeaderAndFooterEnabledFlagToAppearancesTable < ActiveRecord::Migra
   DOWNTIME = false
 
   def up
-    add_column_with_default(:appearances, :email_header_and_footer_enabled, :boolean, default: false) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:appearances, :email_header_and_footer_enabled, :boolean, default: false)
   end
 
   def down

db/migrate/20190228192410_add_multi_line_attributes_to_suggestion.rb

@@ -8,11 +8,9 @@ class AddMultiLineAttributesToSuggestion < ActiveRecord::Migration[5.0]
   disable_ddl_transaction!
 
   def up
-    # rubocop:disable Migration/AddColumnWithDefault
     add_column_with_default :suggestions, :lines_above, :integer, default: 0, allow_null: false
     add_column_with_default :suggestions, :lines_below, :integer, default: 0, allow_null: false
     add_column_with_default :suggestions, :outdated, :boolean, default: false, allow_null: false
-    # rubocop:enable Migration/AddColumnWithDefault
   end
 
   def down

db/migrate/20190322164830_add_auto_ssl_enabled_to_pages_domain.rb

@@ -8,7 +8,7 @@ class AddAutoSslEnabledToPagesDomain < ActiveRecord::Migration[5.0]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :pages_domains, :auto_ssl_enabled, :boolean, default: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :pages_domains, :auto_ssl_enabled, :boolean, default: false
   end
 
   def down

db/migrate/20190325165127_add_managed_to_cluster.rb

@@ -8,7 +8,7 @@ class AddManagedToCluster < ActiveRecord::Migration[5.0]
   DOWNTIME = false
 
   def up
-    add_column_with_default(:clusters, :managed, :boolean, default: true) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:clusters, :managed, :boolean, default: true)
   end
 
   def down

db/migrate/20190415030217_add_variable_type_to_ci_variables.rb

@@ -8,7 +8,7 @@ class AddVariableTypeToCiVariables < ActiveRecord::Migration[5.0]
   ENV_VAR_VARIABLE_TYPE = 1
 
   def up
-    add_column_with_default(:ci_variables, :variable_type, :smallint, default: ENV_VAR_VARIABLE_TYPE) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:ci_variables, :variable_type, :smallint, default: ENV_VAR_VARIABLE_TYPE)
   end
 
   def down

db/migrate/20190416185130_add_merge_train_enabled_to_ci_cd_settings.rb

@@ -8,12 +8,10 @@ class AddMergeTrainEnabledToCiCdSettings < ActiveRecord::Migration[5.1]
   disable_ddl_transaction!
 
   # rubocop:disable Migration/UpdateLargeTable
-  # rubocop:disable Migration/AddColumnWithDefault
   def up
     add_column_with_default :project_ci_cd_settings, :merge_trains_enabled, :boolean, default: false, allow_null: false
   end
   # rubocop:enable Migration/UpdateLargeTable
-  # rubocop:enable Migration/AddColumnWithDefault
 
   def down
     remove_column :project_ci_cd_settings, :merge_trains_enabled

db/migrate/20190416213556_add_variable_type_to_ci_group_variables.rb

@@ -8,7 +8,7 @@ class AddVariableTypeToCiGroupVariables < ActiveRecord::Migration[5.0]
   ENV_VAR_VARIABLE_TYPE = 1
 
   def up
-    add_column_with_default(:ci_group_variables, :variable_type, :smallint, default: ENV_VAR_VARIABLE_TYPE) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:ci_group_variables, :variable_type, :smallint, default: ENV_VAR_VARIABLE_TYPE)
   end
 
   def down

db/migrate/20190416213631_add_variable_type_to_ci_pipeline_schedule_variables.rb

@@ -8,7 +8,7 @@ class AddVariableTypeToCiPipelineScheduleVariables < ActiveRecord::Migration[5.0
   ENV_VAR_VARIABLE_TYPE = 1
 
   def up
-    add_column_with_default(:ci_pipeline_schedule_variables, :variable_type, :smallint, default: ENV_VAR_VARIABLE_TYPE) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:ci_pipeline_schedule_variables, :variable_type, :smallint, default: ENV_VAR_VARIABLE_TYPE)
   end
 
   def down

db/migrate/20190426180107_add_deployment_events_to_services.rb

@@ -8,7 +8,7 @@ class AddDeploymentEventsToServices < ActiveRecord::Migration[5.0]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:services, :deployment_events, :boolean, default: false, allow_null: false) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:services, :deployment_events, :boolean, default: false, allow_null: false)
   end
 
   def down

db/migrate/20190520200123_add_rule_type_to_approval_merge_request_approval_rules.rb

@@ -12,7 +12,7 @@ class AddRuleTypeToApprovalMergeRequestApprovalRules < ActiveRecord::Migration[5
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:approval_merge_request_rules, :rule_type, :integer, limit: 2, default: 1) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:approval_merge_request_rules, :rule_type, :integer, limit: 2, default: 1)
   end
 
   def down

db/migrate/20190607085356_add_source_to_pages_domains.rb

@@ -12,7 +12,7 @@ class AddSourceToPagesDomains < ActiveRecord::Migration[5.1]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:pages_domains, :certificate_source, :smallint, default: 0) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:pages_domains, :certificate_source, :smallint, default: 0)
   end
 
   def down

db/migrate/20190628145246_add_strategies_to_operations_feature_flag_scopes.rb

@@ -8,7 +8,7 @@ class AddStrategiesToOperationsFeatureFlagScopes < ActiveRecord::Migration[5.1]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :operations_feature_flag_scopes, :strategies, :jsonb, default: [{ name: "default", parameters: {} }] # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :operations_feature_flag_scopes, :strategies, :jsonb, default: [{ name: "default", parameters: {} }]
   end
 
   def down

db/migrate/20190709204413_add_rule_type_to_approval_project_rules.rb

@@ -8,7 +8,7 @@ class AddRuleTypeToApprovalProjectRules < ActiveRecord::Migration[5.1]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :approval_project_rules, :rule_type, :integer, limit: 2, default: 0, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :approval_project_rules, :rule_type, :integer, limit: 2, default: 0, allow_null: false
   end
 
   def down

db/migrate/20190712064021_add_namespace_per_environment_flag_to_clusters.rb

@@ -11,7 +11,7 @@ class AddNamespacePerEnvironmentFlagToClusters < ActiveRecord::Migration[5.1]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :clusters, :namespace_per_environment, :boolean, default: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :clusters, :namespace_per_environment, :boolean, default: false
   end
 
   def down

db/migrate/20190715173819_add_object_storage_flag_to_geo_node.rb

@@ -12,7 +12,7 @@ class AddObjectStorageFlagToGeoNode < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :geo_nodes, :sync_object_storage, :boolean, default: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :geo_nodes, :sync_object_storage, :boolean, default: false
   end
 
   def down

db/migrate/20190729180447_add_merge_requests_require_code_owner_approval_to_protected_branches.rb

@@ -9,7 +9,7 @@ class AddMergeRequestsRequireCodeOwnerApprovalToProtectedBranches < ActiveRecord
   disable_ddl_transaction!
 
   def up
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :protected_branches,
       :code_owner_approval_required,
       :boolean,

db/migrate/20190816151221_add_active_jobs_limit_to_plans.rb

@@ -8,7 +8,7 @@ class AddActiveJobsLimitToPlans < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :plans, :active_jobs_limit, :integer, default: 0 # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :plans, :active_jobs_limit, :integer, default: 0
   end
 
   def down

db/migrate/20190901174200_add_max_issue_count_to_list.rb

@@ -7,7 +7,7 @@ class AddMaxIssueCountToList < ActiveRecord::Migration[4.2]
   DOWNTIME = false
 
   def up
-    add_column_with_default :lists, :max_issue_count, :integer, default: 0 # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :lists, :max_issue_count, :integer, default: 0
   end
 
   def down

db/migrate/20190905140605_add_cloud_run_to_clusters_providers_gcp.rb

@@ -8,7 +8,7 @@ class AddCloudRunToClustersProvidersGcp < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:cluster_providers_gcp, :cloud_run, :boolean, default: false) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:cluster_providers_gcp, :cloud_run, :boolean, default: false)
   end
 
   def down

db/migrate/20190907184714_add_show_whitespace_in_diffs_to_user_preferences.rb

@@ -11,7 +11,7 @@ class AddShowWhitespaceInDiffsToUserPreferences < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :user_preferences, :show_whitespace_in_diffs, :boolean, default: true, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :user_preferences, :show_whitespace_in_diffs, :boolean, default: true, allow_null: false
   end
 
   def down

db/migrate/20190918104731_add_cleanup_status_to_cluster.rb

@@ -9,7 +9,7 @@ class AddCleanupStatusToCluster < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:clusters, :cleanup_status, # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:clusters, :cleanup_status,
       :smallint,
       default: 1,
       allow_null: false)

db/migrate/20191014123159_add_expire_notification_delivered_to_personal_access_tokens.rb

@@ -8,7 +8,7 @@ class AddExpireNotificationDeliveredToPersonalAccessTokens < ActiveRecord::Migra
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :personal_access_tokens, :expire_notification_delivered, :boolean, default: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :personal_access_tokens, :expire_notification_delivered, :boolean, default: false
   end
 
   def down

db/migrate/20191023093207_add_comment_actions_to_services.rb

@@ -8,7 +8,7 @@ class AddCommentActionsToServices < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:services, :comment_on_event_enabled, :boolean, default: true) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:services, :comment_on_event_enabled, :boolean, default: true)
   end
 
   def down

db/migrate/20191028130054_add_max_issue_weight_to_list.rb

@@ -8,7 +8,7 @@ class AddMaxIssueWeightToList < ActiveRecord::Migration[5.2]
   DOWNTIME = false
 
   def up
-    add_column_with_default :lists, :max_issue_weight, :integer, default: 0 # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :lists, :max_issue_weight, :integer, default: 0
   end
 
   def down

db/migrate/20191029191901_add_enabled_to_grafana_integrations.rb

@@ -8,7 +8,7 @@ class AddEnabledToGrafanaIntegrations < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :grafana_integrations,
       :enabled,
       :boolean,

db/migrate/20191105155113_add_secret_to_snippet.rb

@@ -9,7 +9,7 @@ class AddSecretToSnippet < ActiveRecord::Migration[5.2]
 
   def up
     unless column_exists?(:snippets, :secret)
-      add_column_with_default :snippets, :secret, :boolean, default: false # rubocop:disable Migration/AddColumnWithDefault
+      add_column_with_default :snippets, :secret, :boolean, default: false
     end
 
     add_concurrent_index :snippets, [:visibility_level, :secret]

db/migrate/20191106144901_add_state_to_merge_trains.rb

@@ -9,7 +9,7 @@ class AddStateToMergeTrains < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :merge_trains, :status, :integer, limit: 2, default: MERGE_TRAIN_STATUS_CREATED # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :merge_trains, :status, :integer, limit: 2, default: MERGE_TRAIN_STATUS_CREATED
   end
 
   def down

db/migrate/20191112090226_add_artifacts_to_ci_build_need.rb

@@ -8,7 +8,7 @@ class AddArtifactsToCiBuildNeed < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:ci_build_needs, :artifacts, # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:ci_build_needs, :artifacts,
                             :boolean,
                             default: true,
                             allow_null: false)

db/migrate/20191121193110_add_issue_links_type.rb

@@ -8,7 +8,7 @@ class AddIssueLinksType < ActiveRecord::Migration[5.1]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :issue_links, :link_type, :integer, default: 0, limit: 2 # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :issue_links, :link_type, :integer, default: 0, limit: 2
   end
 
   def down

db/migrate/20191127163053_add_confidential_to_doorkeeper_application.rb

@@ -8,7 +8,7 @@ class AddConfidentialToDoorkeeperApplication < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :oauth_applications,
       :confidential,
       :boolean,

db/migrate/20191127221608_add_wildcard_and_domain_type_to_pages_domains.rb

@@ -9,10 +9,8 @@ class AddWildcardAndDomainTypeToPagesDomains < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    # rubocop:disable Migration/AddColumnWithDefault
     add_column_with_default :pages_domains, :wildcard, :boolean, default: false
     add_column_with_default :pages_domains, :domain_type, :integer, limit: 2, default: PROJECT_TYPE
-    # rubocop:enable Migration/AddColumnWithDefault
   end
 
   def down

db/migrate/20191129134844_add_broadcast_type_to_broadcast_message.rb

@@ -10,7 +10,7 @@ class AddBroadcastTypeToBroadcastMessage < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default(:broadcast_messages, :broadcast_type, :smallint, default: BROADCAST_MESSAGE_BANNER_TYPE) # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(:broadcast_messages, :broadcast_type, :smallint, default: BROADCAST_MESSAGE_BANNER_TYPE)
   end
 
   def down

db/migrate/20191218124915_add_repository_storage_to_snippets.rb

@@ -8,7 +8,7 @@ class AddRepositoryStorageToSnippets < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :snippets,
       :repository_storage,
       :string,

db/migrate/20191218125015_add_storage_version_to_snippets.rb

@@ -8,7 +8,7 @@ class AddStorageVersionToSnippets < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :snippets,
       :storage_version,
       :integer,

db/migrate/20200122161638_add_deploy_token_type_to_deploy_tokens.rb

@@ -8,7 +8,7 @@ class AddDeployTokenTypeToDeployTokens < ActiveRecord::Migration[5.2]
   DOWNTIME = false
 
   def up
-    add_column_with_default :deploy_tokens, :deploy_token_type, :integer, default: 2, limit: 2, allow_null: false # rubocop: disable Migration/AddColumnWithDefault
+    add_column_with_default :deploy_tokens, :deploy_token_type, :integer, default: 2, limit: 2, allow_null: false
   end
 
   def down

db/migrate/20200128184209_add_usage_to_pages_domains.rb

@@ -9,7 +9,7 @@ class AddUsageToPagesDomains < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :pages_domains, :usage, :integer, limit: 2, default: PAGES_USAGE, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :pages_domains, :usage, :integer, limit: 2, default: PAGES_USAGE, allow_null: false
   end
 
   def down

db/migrate/20200224163804_add_version_to_feature_flags_table.rb

@@ -12,9 +12,7 @@ class AddVersionToFeatureFlagsTable < ActiveRecord::Migration[6.0]
   def up
     # The operations_feature_flags table is small enough that we can disable this cop.
     # See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/25552#note_291202882
-    # rubocop: disable Migration/AddColumnWithDefault
     add_column_with_default(:operations_feature_flags, :version, :smallint, default: FEATURE_FLAG_LEGACY_VERSION, allow_null: false)
-    # rubocop: enable Migration/AddColumnWithDefault
   end
 
   def down

db/post_migrate/20200120083607_remove_storage_version_column_from_snippets.rb

@@ -19,7 +19,7 @@ class RemoveStorageVersionColumnFromSnippets < ActiveRecord::Migration[5.2]
   def down
     return if column_exists?(:snippets, :storage_version)
 
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :snippets,
       :storage_version,
       :integer,

db/post_migrate/20200221142216_remove_repository_storage_from_snippets.rb

@@ -16,7 +16,7 @@ class RemoveRepositoryStorageFromSnippets < ActiveRecord::Migration[6.0]
   def down
     return if column_exists?(:snippets, :repository_storage)
 
-    add_column_with_default( # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default(
       :snippets,
       :repository_storage,
       :string,

ee/db/geo/migrate/20170606155045_add_needs_resync_to_project_registry.rb

@@ -6,10 +6,8 @@ class AddNeedsResyncToProjectRegistry < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    # rubocop:disable Migration/AddColumnWithDefault
     add_column_with_default(:project_registry, :resync_repository, :boolean, default: true)
     add_column_with_default(:project_registry, :resync_wiki, :boolean, default: true)
-    # rubocop:enable Migration/AddColumnWithDefault
   end
 
   def down

ee/db/geo/migrate/20171009162208_add_file_registry_success.rb

@@ -7,7 +7,7 @@ class AddFileRegistrySuccess < ActiveRecord::Migration[4.2]
 
   def up
     # Ensure existing rows are recorded as successes
-    add_column_with_default :file_registry, :success, :boolean, default: true, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :file_registry, :success, :boolean, default: true, allow_null: false
 
     change_column :file_registry, :success, :boolean, default: false
   end

ee/db/geo/migrate/20180323182105_add_missing_on_primary_to_file_registry.rb

@@ -6,7 +6,7 @@ class AddMissingOnPrimaryToFileRegistry < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :file_registry, :missing_on_primary, :boolean, default: false, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :file_registry, :missing_on_primary, :boolean, default: false, allow_null: false
   end
 
   def down

ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb

@@ -6,7 +6,7 @@ class AddMissingOnPrimaryToJobArtifactRegistry < ActiveRecord::Migration[4.2]
   disable_ddl_transaction!
 
   def up
-    add_column_with_default :job_artifact_registry, :missing_on_primary, :boolean, default: false, allow_null: false # rubocop:disable Migration/AddColumnWithDefault
+    add_column_with_default :job_artifact_registry, :missing_on_primary, :boolean, default: false, allow_null: false
   end
 
   def down

rubocop/cop/migration/add_column_with_default.rb

@@ -10,7 +10,37 @@ module RuboCop
       class AddColumnWithDefault < RuboCop::Cop::Cop
         include MigrationHelpers
 
-        WHITELISTED_TABLES = [:application_settings].freeze
+        # Tables >= 10 GB on GitLab.com as of 02/2020
+        BLACKLISTED_TABLES = %i[
+          audit_events
+          ci_build_trace_sections
+          ci_builds
+          ci_builds_metadata
+          ci_job_artifacts
+          ci_pipeline_variables
+          ci_pipelines
+          ci_stages
+          deployments
+          events
+          issues
+          merge_request_diff_commits
+          merge_request_diff_files
+          merge_request_diffs
+          merge_request_metrics
+          merge_requests
+          note_diff_files
+          notes
+          project_authorizations
+          projects
+          push_event_payloads
+          resource_label_events
+          sent_notifications
+          system_note_metadata
+          taggings
+          todos
+          users
+          web_hook_logs
+        ].freeze
 
         MSG = '`add_column_with_default` without `allow_null: true` may cause prolonged lock situations and downtime, ' \
           'see https://gitlab.com/gitlab-org/gitlab/issues/38060'.freeze
@@ -23,21 +53,23 @@ module RuboCop
           return unless in_migration?(node)
 
           add_column_with_default?(node) do |table, options|
-            break if table_whitelisted?(table) || nulls_allowed?(options)
-
-            add_offense(node, location: :selector)
+            add_offense(node, location: :selector) if offensive?(table, options)
           end
         end
 
         private
 
+        def offensive?(table, options)
+          table_blacklisted?(table) && !nulls_allowed?(options)
+        end
+
         def nulls_allowed?(options)
           options.find { |opt| opt.key.value == :allow_null && opt.value.true_type? }
         end
 
-        def table_whitelisted?(symbol)
+        def table_blacklisted?(symbol)
           symbol && symbol.type == :sym &&
-            WHITELISTED_TABLES.include?(symbol.children[0])
+            BLACKLISTED_TABLES.include?(symbol.children[0])
         end
       end
     end

spec/rubocop/cop/migration/add_column_with_default_spec.rb

@@ -16,7 +16,7 @@ describe RuboCop::Cop::Migration::AddColumnWithDefault do
     it 'does not register any offenses' do
       expect_no_offenses(<<~RUBY)
         def up
-          add_column_with_default(:ci_build_needs, :artifacts, :boolean, default: true, allow_null: false)
+          add_column_with_default(:merge_request_diff_files, :artifacts, :boolean, default: true, allow_null: false)
         end
       RUBY
     end
@@ -29,38 +29,42 @@ describe RuboCop::Cop::Migration::AddColumnWithDefault do
 
     let(:offense) { '`add_column_with_default` without `allow_null: true` may cause prolonged lock situations and downtime, see https://gitlab.com/gitlab-org/gitlab/issues/38060' }
 
-    it 'registers an offense when specifying allow_null: false' do
-      expect_offense(<<~RUBY)
-        def up
-          add_column_with_default(:ci_build_needs, :artifacts, :boolean, default: true, allow_null: false)
-          ^^^^^^^^^^^^^^^^^^^^^^^ #{offense}
-        end
-      RUBY
-    end
+    context 'for blacklisted table' do
+      it 'registers an offense when specifying allow_null: false' do
+        expect_offense(<<~RUBY)
+          def up
+            add_column_with_default(:merge_request_diff_files, :artifacts, :boolean, default: true, allow_null: false)
+            ^^^^^^^^^^^^^^^^^^^^^^^ #{offense}
+          end
+        RUBY
+      end
 
-    it 'registers no offense when specifying allow_null: true' do
-      expect_no_offenses(<<~RUBY)
-        def up
-          add_column_with_default(:ci_build_needs, :artifacts, :boolean, default: true, allow_null: true)
-        end
-      RUBY
-    end
+      it 'registers no offense when specifying allow_null: true' do
+        expect_no_offenses(<<~RUBY)
+          def up
+            add_column_with_default(:merge_request_diff_files, :artifacts, :boolean, default: true, allow_null: true)
+          end
+        RUBY
+      end
 
-    it 'registers an offense when allow_null is not specified' do
-      expect_offense(<<~RUBY)
-        def up
-          add_column_with_default(:ci_build_needs, :artifacts, :boolean, default: true)
-          ^^^^^^^^^^^^^^^^^^^^^^^ #{offense}
-        end
-      RUBY
+      it 'registers an offense when allow_null is not specified' do
+        expect_offense(<<~RUBY)
+          def up
+            add_column_with_default(:merge_request_diff_files, :artifacts, :boolean, default: true)
+            ^^^^^^^^^^^^^^^^^^^^^^^ #{offense}
+          end
+        RUBY
+      end
     end
 
-    it 'registers no offense for application_settings (whitelisted table)' do
-      expect_no_offenses(<<~RUBY)
-        def up
-          add_column_with_default(:application_settings, :another_column, :boolean, default: true, allow_null: false)
-        end
-      RUBY
+    context 'for tables not on the blacklist' do
+      it 'registers no offense for application_settings (not on blacklist)' do
+        expect_no_offenses(<<~RUBY)
+          def up
+            add_column_with_default(:application_settings, :another_column, :boolean, default: true, allow_null: false)
+          end
+        RUBY
+      end
     end
   end
 end