Merge branch 'edit-removal-headings' into 'master'

Update MR template and edit removal files for new standard

See merge request gitlab-org/gitlab!80761

data/removals/14_0/14_0-ds-deprecations.yml

-- name: "Deprecations for Dependency Scanning"
+- name: "Dependency Scanning"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: nicoleschwartz

data/removals/14_0/14_0-lc-deprecations.yml

-- name: "Removals for License Compliance"
+- name: "License Compliance"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: nicoleschwartz

data/removals/14_0/create-code-review-w-parameter-removal.yml

-- name: "Remove `?w=1` URL parameter to ignore whitespace changes"
+- name: "`?w=1` URL parameter to ignore whitespace changes"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: phikai

data/removals/14_0/deprecation_bump_terraform_template_version.yml

-- name: "New Terraform template version"
+- name: "Terraform template version"
   removal_date: "2021-06-22"
   removal_milestone: "14.0" # example
   issue_url: ""

data/removals/14_0/deprecation_update_cicd_templates_to_stop_using_hardcode_master.yml

-- name: "Update CI/CD templates to stop using hardcoded `master`"
+- name: "Hardcoded `master` in CI/CD templates"
   reporter: dhershkovitch
   removal_date: "2021-06-22"
   removal_milestone: "14.0"

data/removals/14_0/deuley_servicetemplates_removal.yml

-- name: "Service Templates removed"
+- name: "Service Templates"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deuley

data/removals/14_0/release_announce_deprecation_of_release_notes_api.yml

-- name: "Removal of release description in the Tags API"
+- name: "Release description in the Tags API"
   reporter: kbychu
   removal_date: "2021-06-22"
   removal_milestone: "14.0"

data/removals/14_0/release_deprecation_auto-deploy-image.yml

-- name: "Update Auto Deploy template version"
+- name: "Auto Deploy CI template v1"
   reporter: kbychu
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/300862'
   breaking_change: true
   body: |
-    In GitLab 14.0, we will update the [Auto Deploy](https://docs.gitlab.com/ee/topics/autodevops/stages.html#auto-deploy) CI template to the latest version. This includes new features, bug fixes, and performance improvements with a dependency on the v2 [auto-deploy-image](https://gitlab.com/gitlab-org/cluster-integration/auto-deploy-image). Auto Deploy CI template v1 will is deprecated going forward.
+    In GitLab 14.0, we will update the [Auto Deploy](https://docs.gitlab.com/ee/topics/autodevops/stages.html#auto-deploy) CI template to the latest version. This includes new features, bug fixes, and performance improvements with a dependency on the v2 [auto-deploy-image](https://gitlab.com/gitlab-org/cluster-integration/auto-deploy-image). Auto Deploy CI template v1 is deprecated going forward.
 
     Since the v1 and v2 versions are not backward-compatible, your project might encounter an unexpected failure if you already have a deployed application. Follow the [upgrade guide](https://docs.gitlab.com/ee/topics/autodevops/upgrading_auto_deploy_dependencies.html#upgrade-guide) to upgrade your environments. You can also start using the latest template today by following the [early adoption guide](https://docs.gitlab.com/ee/topics/autodevops/upgrading_auto_deploy_dependencies.html#early-adopters).

data/removals/14_0/release_domainsource_configuration_for_gitlab_pages_deprecation.yml

-- name: "Remove disk source configuration for GitLab Pages"
+- name: "Disk source configuration for GitLab Pages"
   reporter: kbychu
   removal_date: "2021-06-22"
   removal_milestone: "14.0"

data/removals/14_0/release_legacy_feature_flags_deprecation.yml

-- name: "Legacy feature flags removed"
+- name: "Legacy feature flags"
   reporter: kbychu
   removal_date: "2021-06-22"
   removal_milestone: "14.0"

data/removals/14_0/release_remove_redundant_keyvalue_pair_from_the_payload_of_dora.yml

-- name: "Remove redundant timestamp field from DORA metrics API payload"
+- name: "Redundant timestamp field from DORA metrics API payload"
   reporter: kbychu
   removal_date: "2021-06-22"
   removal_milestone: "14.0"

data/removals/14_0/removal-geo-fdw-settings.yml

-- name: "Geo Foreign Data Wrapper settings removed"
+- name: "Geo Foreign Data Wrapper settings"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: fzimmer

data/removals/14_0/removal-graphql-fields.yml

-- name: "Deprecated GraphQL fields have been removed"
+- name: "Deprecated GraphQL fields"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: gweaver

data/removals/14_0/removal-legacy-storage.yml

-- name: "Legacy storage removed"
+- name: "Legacy storage"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: fzimmer

data/removals/14_0/removal-sidekiq_experimental_queue_selector.yml

-- name: Sidekiq queue selector options no longer accept the 'experimental' prefix
+- name: Experimental prefix in Sidekiq queue selector options
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: smcgivern

data/removals/14_0/removal-unicorn.yml

-- name: "Unicorn removed in favor of Puma for GitLab self-managed"
+- name: "Unicorn in GitLab self-managed"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: fzimmer

data/removals/14_0/removal_ci_project_config_path.yml

-- name: "`CI_PROJECT_CONFIG_PATH` variable has been removed"
+- name: "`CI_PROJECT_CONFIG_PATH` variable"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: stkerr

data/removals/14_0/removal_repost_static_analysis_notices.yml

@@ -8,7 +8,7 @@
     Until GitLab 13.9, if you wanted to avoid running one particular GitLab SAST analyzer, you needed to remove it from the [long string of analyzers in the `SAST.gitlab-ci.yml` file](https://gitlab.com/gitlab-org/gitlab/-/blob/390afc431e7ce1ac253b35beb39f19e49c746bff/lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml#L12) and use that to set the [`SAST_DEFAULT_ANALYZERS`](https://docs.gitlab.com/ee/user/application_security/sast/#docker-images) variable in your project's CI file. If you did this, it would exclude you from future new analyzers because this string hard codes the list of analyzers to execute. We avoid this problem by inverting this variable's logic to exclude, rather than choose default analyzers.
     Beginning with 13.9, [we migrated](https://gitlab.com/gitlab-org/gitlab/-/blob/14fed7a33bfdbd4663d8928e46002a5ef3e3282c/lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml#L13) to `SAST_EXCLUDED_ANALYZERS` in our `SAST.gitlab-ci.yml` file. We encourage anyone who uses a [customized SAST configuration](https://docs.gitlab.com/ee/user/application_security/sast/#customizing-the-sast-settings) in their project CI file to migrate to this new variable. If you have not overridden `SAST_DEFAULT_ANALYZERS`, no action is needed. The CI/CD variable `SAST_DEFAULT_ANALYZERS` has been removed in GitLab 14.0, which released on June 22, 2021.
 
-- name: "Remove `secret_detection_default_branch` job"
+- name: "`secret_detection_default_branch` job"
   reporter: tmccaslin
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
@@ -18,8 +18,7 @@
     To ensure Secret Detection was scanning both default branches and feature branches, we introduced two separate secret detection CI jobs (`secret_detection_default_branch` and `secret_detection`) in our managed [`Secret-Detection.gitlab-ci.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/templates/Security/Secret-Detection.gitlab-ci.yml) template. These two CI jobs created confusion and complexity in the CI rules logic. This deprecation moves the `rule` logic into the `script` section, which then determines how the `secret_detection` job is run (historic, on a branch, commits, etc).
     If you override or maintain custom versions of `SAST.gitlab-ci.yml` or `Secret-Detection.gitlab-ci.yml`, you must update your CI templates. We strongly encourage [inheriting and overriding our managed CI templates](https://docs.gitlab.com/ee/user/application_security/secret_detection/#custom-settings-example) to future-proof your CI templates. GitLab 14.0 no longer supports the old `secret_detection_default_branch` job.
 
-- name: "Remove SAST analyzer `SAST_GOSEC_CONFIG` variable in favor of
-    custom rulesets"
+- name: "SAST analyzer `SAST_GOSEC_CONFIG` variable"
   reporter: tmccaslin
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
@@ -29,7 +28,7 @@
     With the release of [SAST Custom Rulesets](https://docs.gitlab.com/ee/user/application_security/sast/#customize-rulesets) in GitLab 13.5 we allow greater flexibility in configuration options for our Go analyzer (GoSec). As a result we no longer plan to support our less flexible [`SAST_GOSEC_CONFIG`](https://docs.gitlab.com/ee/user/application_security/sast/#analyzer-settings) analyzer setting. This variable was deprecated in GitLab 13.10.
     GitLab 14.0 removes the old `SAST_GOSEC_CONFIG variable`. If you use or override `SAST_GOSEC_CONFIG` in your CI file, update your SAST CI configuration or pin to an older version of the GoSec analyzer. We strongly encourage [inheriting and overriding our managed CI templates](https://docs.gitlab.com/ee/user/application_security/sast/#overriding-sast-jobs) to future-proof your CI templates.
 
-- name: "Removed Global `SAST_ANALYZER_IMAGE_TAG` in SAST CI template"
+- name: "Global `SAST_ANALYZER_IMAGE_TAG` in SAST CI template"
   reporter: tmccaslin
   removal_date: "2021-06-22"
   removal_milestone: "14.0"

data/removals/14_0/removal_runner_25555.yml

-- name: "Remove off peak time mode configuration for Docker Machine autoscaling"
+- name: "Off peak time mode configuration for Docker Machine autoscaling"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removal_runner_26036.yml

-- name: "Remove Ubuntu 19.10 (Eoan Ermine) package"
+- name: "Ubuntu 19.10 (Eoan Ermine) package"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removal_runner_6413.yml

-- name: "Remove `FF_SHELL_EXECUTOR_USE_LEGACY_PROCESS_KILL` feature flag"
+- name: "`FF_SHELL_EXECUTOR_USE_LEGACY_PROCESS_KILL` feature flag"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removals_runner_26651.yml

-- name: "Remove `/usr/lib/gitlab-runner` symlink from package"
+- name: "`/usr/lib/gitlab-runner` symlink from package"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removals_runner_26679.yml

-- name: "Remove `FF_RESET_HELPER_IMAGE_ENTRYPOINT` feature flag"
+- name: "`FF_RESET_HELPER_IMAGE_ENTRYPOINT` feature flag"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removals_runner_26900.yml

-- name: "Remove success and failure for finished build metric conversion"
+- name: "Success and failure for finished build metric conversion"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removals_runner_27175.yml

-- name: "Remove `FF_USE_GO_CLOUD_WITH_CACHE_ARCHIVER` feature flag"
+- name: "`FF_USE_GO_CLOUD_WITH_CACHE_ARCHIVER` feature flag"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removals_runner_27551.yml

-- name: "Remove support for Windows Server 1903 image"
+- name: "Windows Server 1903 image support"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/removals_runner_27899.yml

-- name: "Remove support for Windows Server 1909 image"
+- name: "Windows Server 1909 image support"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman

data/removals/14_0/remove-sql-elector.yml

-- name: "Gitaly Cluster SQL primary elector has been removed"
+- name: "Gitaly Cluster SQL primary elector"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: mjwood

data/removals/14_0/remove_dast_legacy_domain_validation.yml

-- name: "Remove legacy DAST domain validation"
+- name: "Legacy DAST domain validation"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson

data/removals/14_0/remove_dast_legacy_report_fields.yml

-- name: "Removal of legacy fields from DAST report"
+- name: "Legacy fields from DAST report"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson

data/removals/14_0/remove_dast_template_stages.yml

-- name: "Remove DAST default template stages"
+- name: "DAST default template stages"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson

data/removals/14_0/remove_optimize_api.yml

-- name: "Segments removed from DevOps Adoption API"
+- name: "DevOps Adoption API Segments"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: ljlane

data/removals/14_0/verify-ci-removal-parametertrace.yml

-- name: "Removal of deprecated `trace` parameter from `jobs` API endpoint"
+- name: "`trace` parameter in `jobs` API"
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: jreporter

data/removals/templates/example.yml

@@ -9,7 +9,7 @@
 #
 # Please delete this line and above before submitting your merge request.
 
-- name: "Announcement headline"  # The headline announcing the removal. i.e. "`CI_PROJECT_CONFIG_PATH` removed in Gitlab 14.0"
+- name: "Feature name"  # the name of the feature being removed. Avoid the words `deprecation`, `deprecate`, `removal`, and `remove` in this field because these are implied.
   announcement_milestone: "XX.YY"  # The milestone when this feature was deprecated.
   announcement_date: "YYYY-MM-DD"  # The date of the milestone release when this feature was deprecated. This should almost always be the 22nd of a month (YYYY-MM-DD), unless you did an out of band blog post.
   removal_milestone: "XX.YY"  # The milestone when this feature is being removed.