Commit 896b2c2e authored by Sanad Liaquat's avatar Sanad Liaquat

Merge branch 'qa-update-jira-integration-selectors' into 'master'

Update Jira integration qa selectors

Closes #225801

See merge request gitlab-org/gitlab!35914
parents 4d9ab71a 174354dd
...@@ -162,6 +162,7 @@ export default { ...@@ -162,6 +162,7 @@ export default {
autocomplete="new-password" autocomplete="new-password"
:placeholder="placeholder" :placeholder="placeholder"
:required="passwordRequired" :required="passwordRequired"
:data-qa-selector="`${fieldId}_field`"
/> />
<gl-form-input <gl-form-input
v-else v-else
...@@ -170,6 +171,7 @@ export default { ...@@ -170,6 +171,7 @@ export default {
:type="type" :type="type"
:placeholder="placeholder" :placeholder="placeholder"
:required="required" :required="required"
:data-qa-selector="`${fieldId}_field`"
/> />
</gl-form-group> </gl-form-group>
</template> </template>
...@@ -6,11 +6,11 @@ module QA ...@@ -6,11 +6,11 @@ module QA
module Settings module Settings
module Services module Services
class Jira < QA::Page::Base class Jira < QA::Page::Base
view 'app/views/shared/_field.html.haml' do view 'app/assets/javascripts/integrations/edit/components/dynamic_field.vue' do
element :url_field, 'data: { qa_selector: "#{name.downcase.gsub' # rubocop:disable QA/ElementWithPattern element :service_url_field, ':data-qa-selector="`${fieldId}_field`"' # rubocop:disable QA/ElementWithPattern
element :username_field, 'data: { qa_selector: "#{name.downcase.gsub' # rubocop:disable QA/ElementWithPattern element :service_username_field, ':data-qa-selector="`${fieldId}_field`"' # rubocop:disable QA/ElementWithPattern
element :password_field, 'data: { qa_selector: "#{name.downcase.gsub' # rubocop:disable QA/ElementWithPattern element :service_password_field, ':data-qa-selector="`${fieldId}_field`"' # rubocop:disable QA/ElementWithPattern
element :jira_issue_transition_id_field, 'data: { qa_selector: "#{name.downcase.gsub' # rubocop:disable QA/ElementWithPattern element :service_jira_issue_transition_id_field, ':data-qa-selector="`${fieldId}_field`"' # rubocop:disable QA/ElementWithPattern
end end
view 'app/helpers/services_helper.rb' do view 'app/helpers/services_helper.rb' do
...@@ -34,19 +34,19 @@ module QA ...@@ -34,19 +34,19 @@ module QA
private private
def set_jira_server_url(url) def set_jira_server_url(url)
fill_element(:url_field, url) fill_element(:service_url_field, url)
end end
def set_username(username) def set_username(username)
fill_element(:username_field, username) fill_element(:service_username_field, username)
end end
def set_password(password) def set_password(password)
fill_element(:password_field, password) fill_element(:service_password_field, password)
end end
def set_transaction_ids(transaction_ids) def set_transaction_ids(transaction_ids)
fill_element(:jira_issue_transition_id_field, transaction_ids) fill_element(:service_jira_issue_transition_id_field, transaction_ids)
end end
def click_save_changes_button def click_save_changes_button
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment