Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8979fcf4
Commit
8979fcf4
authored
Nov 04, 2021
by
Paul Gascou-Vaillancourt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update broken specs
Updates specs that were broken due to a new prop being introduced in GlTruncate.
parent
e76d927d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
85 additions
and
56 deletions
+85
-56
ee/spec/frontend/security_dashboard/components/shared/vulnerability_list_spec.js
...ty_dashboard/components/shared/vulnerability_list_spec.js
+42
-28
ee/spec/frontend/security_dashboard/components/shared/vulnerability_report/vulnerability_list_spec.js
...ts/shared/vulnerability_report/vulnerability_list_spec.js
+42
-28
spec/frontend/packages_and_registries/package_registry/components/details/__snapshots__/version_row_spec.js.snap
...components/details/__snapshots__/version_row_spec.js.snap
+1
-0
No files found.
ee/spec/frontend/security_dashboard/components/shared/vulnerability_list_spec.js
View file @
8979fcf4
...
...
@@ -234,30 +234,36 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
0
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
image
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
image
,
position
:
'
middle
'
,
}),
);
});
it
(
'
should display the vulnerability locations for code
'
,
()
=>
{
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
1
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
}),
);
});
it
(
'
should display the vulnerability locations for code with no line data
'
,
()
=>
{
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
2
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
file
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
file
,
position
:
'
middle
'
,
}),
);
});
it
(
'
should not display the vulnerability locations for vulnerabilities without a location
'
,
()
=>
{
...
...
@@ -271,10 +277,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
5
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
path
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
path
,
position
:
'
middle
'
,
}),
);
});
});
...
...
@@ -295,10 +303,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
0
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
not
.
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
image
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
image
,
position
:
'
middle
'
,
}),
);
});
it
(
'
should display the detected time
'
,
()
=>
{
...
...
@@ -312,10 +322,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
1
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
not
.
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
}),
);
});
it
(
'
should make the file path linkable
'
,
()
=>
{
...
...
@@ -334,10 +346,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
2
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
not
.
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
file
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
file
,
position
:
'
middle
'
,
}),
);
});
});
...
...
ee/spec/frontend/security_dashboard/components/shared/vulnerability_report/vulnerability_list_spec.js
View file @
8979fcf4
...
...
@@ -219,30 +219,36 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
0
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
image
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
image
,
position
:
'
middle
'
,
}),
);
});
it
(
'
should display the vulnerability locations for code
'
,
()
=>
{
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
1
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
}),
);
});
it
(
'
should display the vulnerability locations for code with no line data
'
,
()
=>
{
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
2
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
file
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
file
,
position
:
'
middle
'
,
}),
);
});
it
(
'
should not display the vulnerability locations for vulnerabilities without a location
'
,
()
=>
{
...
...
@@ -256,10 +262,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
5
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
path
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
path
,
position
:
'
middle
'
,
}),
);
});
});
...
...
@@ -280,10 +288,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
0
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
not
.
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
image
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
image
,
position
:
'
middle
'
,
}),
);
});
it
(
'
should display the detected time
'
,
()
=>
{
...
...
@@ -297,10 +307,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
1
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
not
.
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
locationText
(
location
),
position
:
'
middle
'
,
}),
);
});
it
(
'
should make the file path linkable
'
,
()
=>
{
...
...
@@ -319,10 +331,12 @@ describe('Vulnerability list component', () => {
const
{
id
,
project
,
location
}
=
newVulnerabilities
[
2
];
const
cell
=
findLocationCell
(
id
);
expect
(
cell
.
text
()).
not
.
toContain
(
project
.
nameWithNamespace
);
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
({
text
:
location
.
file
,
position
:
'
middle
'
,
});
expect
(
findLocationTextWrapper
(
cell
).
props
()).
toEqual
(
expect
.
objectContaining
({
text
:
location
.
file
,
position
:
'
middle
'
,
}),
);
});
});
...
...
spec/frontend/packages_and_registries/package_registry/components/details/__snapshots__/version_row_spec.js.snap
View file @
8979fcf4
...
...
@@ -27,6 +27,7 @@ exports[`VersionRow renders 1`] = `
>
<span
class="gl-truncate"
data-testid="truncate-end-container"
title="@gitlab-org/package-15"
>
<span
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment