Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8b337e15
Commit
8b337e15
authored
Sep 28, 2020
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `ci_bulk_insert_on_create` feature flag
This removes a feature flag that is already `default_enabled: true`
parent
3fd9cc8a
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
2 additions
and
13 deletions
+2
-13
app/services/ci/retry_build_service.rb
app/services/ci/retry_build_service.rb
+1
-1
config/feature_flags/development/ci_bulk_insert_on_create.yml
...ig/feature_flags/development/ci_bulk_insert_on_create.yml
+0
-7
lib/gitlab/ci/features.rb
lib/gitlab/ci/features.rb
+0
-4
lib/gitlab/ci/pipeline/chain/create.rb
lib/gitlab/ci/pipeline/chain/create.rb
+1
-1
No files found.
app/services/ci/retry_build_service.rb
View file @
8b337e15
...
...
@@ -58,7 +58,7 @@ module Ci
build
=
project
.
builds
.
new
(
attributes
)
build
.
assign_attributes
(
::
Gitlab
::
Ci
::
Pipeline
::
Seed
::
Build
.
environment_attributes_for
(
build
))
build
.
retried
=
false
BulkInsertableAssociations
.
with_bulk_insert
(
enabled:
::
Gitlab
::
Ci
::
Features
.
bulk_insert_on_create?
(
project
))
do
BulkInsertableAssociations
.
with_bulk_insert
do
build
.
save!
end
build
...
...
config/feature_flags/development/ci_bulk_insert_on_create.yml
deleted
100644 → 0
View file @
3fd9cc8a
---
name
:
ci_bulk_insert_on_create
introduced_by_url
:
rollout_issue_url
:
group
:
type
:
development
default_enabled
:
true
lib/gitlab/ci/features.rb
View file @
8b337e15
...
...
@@ -35,10 +35,6 @@ module Gitlab
::
Feature
.
enabled?
(
:ci_raise_job_rules_without_workflow_rules_warning
,
default_enabled:
true
)
end
def
self
.
bulk_insert_on_create?
(
project
)
::
Feature
.
enabled?
(
:ci_bulk_insert_on_create
,
project
,
default_enabled:
true
)
end
# NOTE: The feature flag `disallow_to_create_merge_request_pipelines_in_target_project`
# is a safe switch to disable the feature for a parituclar project when something went wrong,
# therefore it's not supposed to be enabled by default.
...
...
lib/gitlab/ci/pipeline/chain/create.rb
View file @
8b337e15
...
...
@@ -8,7 +8,7 @@ module Gitlab
include
Chain
::
Helpers
def
perform!
BulkInsertableAssociations
.
with_bulk_insert
(
enabled:
::
Gitlab
::
Ci
::
Features
.
bulk_insert_on_create?
(
project
))
do
BulkInsertableAssociations
.
with_bulk_insert
do
pipeline
.
save!
end
rescue
ActiveRecord
::
RecordInvalid
=>
e
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment