Merge branch 'add_link_to_vulnerability_from_issue' into 'master'

Add link to vulnerability from created issue

See merge request gitlab-org/gitlab!43046

ee/app/helpers/ee/gitlab_routing_helper.rb

@@ -38,6 +38,10 @@ module EE
       project_security_vulnerability_path(entity.project, entity, *args)
     end
 
+    def vulnerability_url(vulnerability)
+      ::Gitlab::UrlBuilder.build(vulnerability)
+    end
+
     def project_vulnerability_path(project, vulnerability, *args)
       project_security_vulnerability_path(project, vulnerability, *args)
     end

ee/app/views/vulnerabilities/issue_description.md.erb

+<% if vulnerability.is_a? Vulnerability %>
+<%= _("Issue created from vulnerability %{vulnerability_link}".html_safe) % { vulnerability_link: link_to(vulnerability.id, vulnerability_url(vulnerability)) } %>
+
+<% end %>
 ### <%= _("Description") %>:
 
 <%= vulnerability.description %>

ee/changelogs/unreleased/add_link_to_vulnerability_from_issue.yml

+---
+title: Add link to vulnerability from created issue
+merge_request: 43046
+author:
+type: changed

ee/spec/helpers/ee/gitlab_routing_helper_spec.rb

@@ -142,4 +142,14 @@ RSpec.describe EE::GitlabRoutingHelper do
       end
     end
   end
+
+  describe '#vulnerability_url' do
+    let_it_be(:vulnerability) { create(:vulnerability) }
+
+    subject { vulnerability_url(vulnerability) }
+
+    it 'returns the full url of the vulnerability' do
+      expect(subject).to eq "http://localhost/#{vulnerability.project.namespace.path}/#{vulnerability.project.name}/-/security/vulnerabilities/#{vulnerability.id}"
+    end
+  end
 end

ee/spec/services/ee/issues/create_from_vulnerability_service_spec.rb

@@ -97,6 +97,8 @@ RSpec.describe Issues::CreateFromVulnerabilityService, '#execute' do
       let(:expected_title) { "Investigate vulnerability: #{vulnerability.title}" }
       let(:expected_description) do
         <<~DESC.chomp
+          Issue created from vulnerability <a href="http://localhost/#{group.name}/#{project.name}/-/security/vulnerabilities/#{vulnerability.id}">#{vulnerability.id}</a>
+
           ### Description:
 
           Description of #{vulnerability.title}

locale/gitlab.pot

@@ -14120,6 +14120,9 @@ msgstr ""
 msgid "Issue cannot be found."
 msgstr ""
 
+msgid "Issue created from vulnerability %{vulnerability_link}"
+msgstr ""
+
 msgid "Issue events"
 msgstr ""