Merge branch 'issue#325836-fix-empty-line-after-let-it-be-api-helpers' into 'master'

Fix EmptyLineAfterFinalLetItBe Rubocop offenses for api helpers

See merge request gitlab-org/gitlab!58194

.rubocop_manual_todo.yml

@@ -763,8 +763,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/api/entities/design_management/design_spec.rb
     - spec/lib/api/entities/merge_request_changes_spec.rb
     - spec/lib/api/entities/release_spec.rb
-    - spec/lib/api/helpers/caching_spec.rb
-    - spec/lib/api/helpers/packages_manager_clients_helpers_spec.rb
     - spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
     - spec/lib/extracts_path_spec.rb
     - spec/lib/extracts_ref_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-api-helpers.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe Rubocop offenses for api helpers
+merge_request: 58194
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/api/helpers/caching_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe API::Helpers::Caching do
   describe "#present_cached" do
     let_it_be(:project) { create(:project) }
     let_it_be(:user) { create(:user) }
+
     let(:presenter) { API::Entities::Todo }
 
     let(:kwargs) do

spec/lib/api/helpers/packages_manager_clients_helpers_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe API::Helpers::PackagesManagerClientsHelpers do
   let_it_be(:personal_access_token) { create(:personal_access_token) }
   let_it_be(:username) { personal_access_token.user.username }
   let_it_be(:helper) { Class.new.include(described_class).new }
+
   let(:password) { personal_access_token.token }
 
   let(:env) do
@@ -50,6 +51,7 @@ RSpec.describe API::Helpers::PackagesManagerClientsHelpers do
 
   describe '#find_job_from_http_basic_auth' do
     let_it_be(:user) { personal_access_token.user }
+
     let(:job) { create(:ci_build, user: user, status: :running) }
     let(:password) { job.token }
 
@@ -74,6 +76,7 @@ RSpec.describe API::Helpers::PackagesManagerClientsHelpers do
 
   describe '#find_deploy_token_from_http_basic_auth' do
     let_it_be(:deploy_token) { create(:deploy_token) }
+
     let(:token) { deploy_token.token }
     let(:username) { deploy_token.username }
     let(:password) { token }