Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8e0d8bde
Commit
8e0d8bde
authored
Jun 18, 2021
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply 6 suggestion(s) to 3 file(s)
parent
f3658bdb
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
ee/spec/requests/projects/issue_feature_flags_controller_spec.rb
.../requests/projects/issue_feature_flags_controller_spec.rb
+1
-1
ee/spec/services/issue_feature_flags/list_service_spec.rb
ee/spec/services/issue_feature_flags/list_service_spec.rb
+4
-4
spec/models/ability_spec.rb
spec/models/ability_spec.rb
+1
-1
No files found.
ee/spec/requests/projects/issue_feature_flags_controller_spec.rb
View file @
8e0d8bde
...
@@ -83,7 +83,7 @@ RSpec.describe Projects::IssueFeatureFlagsController do
...
@@ -83,7 +83,7 @@ RSpec.describe Projects::IssueFeatureFlagsController do
stub_licensed_features
(
feature_flags_related_issues:
false
)
stub_licensed_features
(
feature_flags_related_issues:
false
)
end
end
it
'
does not return linked issues
'
do
it
'
returns not found
'
do
feature_flag
,
_
,
_
=
setup
feature_flag
,
_
,
_
=
setup
sign_in
(
developer
)
sign_in
(
developer
)
...
...
ee/spec/services/issue_feature_flags/list_service_spec.rb
View file @
8e0d8bde
...
@@ -21,7 +21,7 @@ RSpec.describe IssueFeatureFlags::ListService do
...
@@ -21,7 +21,7 @@ RSpec.describe IssueFeatureFlags::ListService do
create
(
:feature_flag_issue
,
feature_flag:
feature_flag
,
issue:
issue
)
create
(
:feature_flag_issue
,
feature_flag:
feature_flag
,
issue:
issue
)
end
end
context
'user can see feature flags'
do
context
'
when
user can see feature flags'
do
before
do
before
do
project
.
add_developer
(
user
)
project
.
add_developer
(
user
)
end
end
...
@@ -32,7 +32,7 @@ RSpec.describe IssueFeatureFlags::ListService do
...
@@ -32,7 +32,7 @@ RSpec.describe IssueFeatureFlags::ListService do
expect
{
described_class
.
new
(
issue
,
user
).
execute
}.
not_to
exceed_query_limit
(
control_count
)
expect
{
described_class
.
new
(
issue
,
user
).
execute
}.
not_to
exceed_query_limit
(
control_count
)
end
end
it
'returns related
issue
s'
do
it
'returns related
feature flag
s'
do
expect
(
subject
.
size
).
to
eq
(
4
)
expect
(
subject
.
size
).
to
eq
(
4
)
expect
(
subject
).
to
include
(
include
(
id:
feature_flag
.
id
,
expect
(
subject
).
to
include
(
include
(
id:
feature_flag
.
id
,
...
@@ -50,8 +50,8 @@ RSpec.describe IssueFeatureFlags::ListService do
...
@@ -50,8 +50,8 @@ RSpec.describe IssueFeatureFlags::ListService do
end
end
end
end
context
'user can not see feature flags'
do
context
'
when
user can not see feature flags'
do
it
'returns
related issues
'
do
it
'returns
nothing
'
do
expect
(
subject
.
size
).
to
eq
(
0
)
expect
(
subject
.
size
).
to
eq
(
0
)
end
end
end
end
...
...
spec/models/ability_spec.rb
View file @
8e0d8bde
...
@@ -362,7 +362,7 @@ RSpec.describe Ability do
...
@@ -362,7 +362,7 @@ RSpec.describe Ability do
cross_project
.
add_developer
(
user
)
cross_project
.
add_developer
(
user
)
end
end
it
'returns
project
s visible to the user'
do
it
'returns
feature flag
s visible to the user'
do
expect
(
readable_feature_flags
).
to
contain_exactly
(
feature_flag
,
cross_project_feature_flag
)
expect
(
readable_feature_flags
).
to
contain_exactly
(
feature_flag
,
cross_project_feature_flag
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment