Commit 8e70cf25 authored by Rémy Coutable's avatar Rémy Coutable

Addresses Robert's feedback

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent 33ce1976
...@@ -436,7 +436,7 @@ Parameters: ...@@ -436,7 +436,7 @@ Parameters:
### Get project events ### Get project events
Get the events for the specified project. Get the events for the specified project.
Sorted from newest to latest Sorted from newest to oldest
``` ```
GET /projects/:id/events GET /projects/:id/events
......
...@@ -630,7 +630,7 @@ Will return `200 OK` on success, `404 User Not Found` is user cannot be found or ...@@ -630,7 +630,7 @@ Will return `200 OK` on success, `404 User Not Found` is user cannot be found or
### Get user contribution events ### Get user contribution events
Get the contribution events for the specified user, sorted from newest to latest. Get the contribution events for the specified user, sorted from newest to oldest.
``` ```
GET /users/:id/events GET /users/:id/events
......
...@@ -898,7 +898,6 @@ describe API::API, api: true do ...@@ -898,7 +898,6 @@ describe API::API, api: true do
describe 'GET /user/:id/events' do describe 'GET /user/:id/events' do
let(:user) { create(:user) } let(:user) { create(:user) }
let(:lambda_user) { create(:user) }
let(:project) { create(:empty_project) } let(:project) { create(:empty_project) }
let(:note) { create(:note_on_issue, note: 'What an awesome day!', project: project) } let(:note) { create(:note_on_issue, note: 'What an awesome day!', project: project) }
...@@ -909,7 +908,9 @@ describe API::API, api: true do ...@@ -909,7 +908,9 @@ describe API::API, api: true do
context "as a user than cannot see the event's project" do context "as a user than cannot see the event's project" do
it 'returns no events' do it 'returns no events' do
get api("/users/#{user.id}/events", lambda_user) other_user = create(:user)
get api("/users/#{user.id}/events", other_user)
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
expect(json_response).to be_empty expect(json_response).to be_empty
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment