Merge branch '273798-remove-group-coverage-data-report-feature-flag' into 'master'

Remove the group_coverage_data_report flag

See merge request gitlab-org/gitlab!47572

doc/api/graphql/reference/gitlab_schema.graphql

@@ -14967,8 +14967,7 @@ type Project {
   ): ClusterAgentConnection
 
   """
-  Code coverages summary associated with the project. Available only when
-  feature flag `group_coverage_data_report` is enabled
+  Code coverage summary associated with the project
   """
   codeCoverageSummary: CodeCoverageSummary
 

doc/api/graphql/reference/gitlab_schema.json

@@ -44149,7 +44149,7 @@
             },
             {
               "name": "codeCoverageSummary",
-              "description": "Code coverages summary associated with the project. Available only when feature flag `group_coverage_data_report` is enabled",
+              "description": "Code coverage summary associated with the project",
               "args": [
 
               ],

doc/api/graphql/reference/index.md

@@ -2257,7 +2257,7 @@ Autogenerated return type of PipelineRetry.
 | `boards` | BoardConnection | Boards of the project |
 | `clusterAgent` | ClusterAgent | Find a single cluster agent by name |
 | `clusterAgents` | ClusterAgentConnection | Cluster agents associated with the project |
-| `codeCoverageSummary` | CodeCoverageSummary | Code coverages summary associated with the project. Available only when feature flag `group_coverage_data_report` is enabled |
+| `codeCoverageSummary` | CodeCoverageSummary | Code coverage summary associated with the project |
 | `complianceFrameworks` | ComplianceFrameworkConnection | Compliance frameworks associated with the project |
 | `containerExpirationPolicy` | ContainerExpirationPolicy | The container expiration policy of the project |
 | `containerRegistryEnabled` | Boolean | Indicates if the project stores Docker container images in a container registry |

doc/user/group/repositories_analytics/index.md

@@ -15,22 +15,12 @@ This feature might not be available to you. Check the **version history** note a
 ## Latest project test coverage list
 
 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/267624) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.6.
-> - It's [deployed behind a feature flag](../../../user/feature_flags.md), disabled by default.
-> - It's disabled on GitLab.com
-> - It can be enabled or disabled per-group.
-> - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enable-or-disable-latest-project-test-coverage).
 
 To see the latest code coverage for each project in your group:
 
 1. Go to **Analytics > Repositories** in the group (not from a project).
 1. In the **Latest test coverage results** section, use the **Select projects** dropdown to choose the projects you want to check.
 
-### Enable or disable latest project test coverage
-
-This feature comes with the `:group_coverage_data_report` feature flag disabled by default. It is disabled on GitLab.com.
-[GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md) can enable it for your instance.
-The group test coverage table can be enabled or disabled per-group.
-
 ## Download historic test coverage data
 
 > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/215104) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.4.

ee/app/assets/javascripts/analytics/repository_analytics/components/group_repository_analytics.vue

@@ -20,9 +20,6 @@ export default {
     shouldShowCoverageSummary() {
       return this.glFeatures.groupCoverageDataReportGraph;
     },
-    shouldShowCoverageReport() {
-      return this.glFeatures.groupCoverageDataReport;
-    },
   },
 };
 </script>
@@ -33,7 +30,7 @@ export default {
       {{ $options.text.codeCoverageHeader }}
     </h4>
     <test-coverage-summary v-if="shouldShowCoverageSummary" />
-    <test-coverage-table v-if="shouldShowCoverageReport" class="gl-mb-5" />
+    <test-coverage-table class="gl-mb-5" />
     <download-test-coverage />
   </div>
 </template>

ee/app/controllers/groups/analytics/repository_analytics_controller.rb

@@ -6,7 +6,6 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl
   before_action :load_group
   before_action -> { check_feature_availability!(:group_repository_analytics) }
   before_action -> { authorize_view_by_action!(:read_group_repository_analytics) }
-  before_action -> { push_frontend_feature_flag(:group_coverage_data_report, @group, default_enabled: false) }
   before_action -> { push_frontend_feature_flag(:group_coverage_data_report_graph, @group, default_enabled: false) }
 
   def show

ee/app/graphql/ee/types/project_type.rb

@@ -145,9 +145,8 @@ module EE
         field :code_coverage_summary,
               ::Types::Ci::CodeCoverageSummaryType,
               null: true,
-              description: 'Code coverages summary associated with the project',
-              resolver: ::Resolvers::Ci::CodeCoverageSummaryResolver,
-              feature_flag: :group_coverage_data_report
+              description: 'Code coverage summary associated with the project',
+              resolver: ::Resolvers::Ci::CodeCoverageSummaryResolver
 
         def self.sast_ci_configuration(project)
           ::Security::CiConfiguration::SastParserService.new(project).configuration

ee/changelogs/unreleased/273798-remove-group-coverage-data-report-feature-flag.yml

+---
+title: Add latest project test coverage list to group repositories analytics
+merge_request: 47572
+author:
+type: added

ee/config/feature_flags/development/group_coverage_data_report.yml

----
-name: group_coverage_data_report
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43774
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/215135/
-milestone: '13.5'
-type: development
-group: group::testing
-default_enabled: false

ee/spec/requests/api/graphql/project/code_coverage_summary_spec.rb

@@ -67,13 +67,4 @@ RSpec.describe 'Getting code coverage summary in a project' do
       expect(code_coverage_summary_graphql_data).to be_nil
     end
   end
-
-  context 'when group_coverage_data_report flag is disabled' do
-    it 'returns a graphQL error field does not exist' do
-      stub_feature_flags(group_coverage_data_report: false)
-
-      post_graphql(query, current_user: current_user)
-      expect_graphql_errors_to_include(/Field 'codeCoverageSummary' doesn't exist on type 'Project'/)
-    end
-  end
 end