Commit 93cb0943 authored by Brandon Labuschagne's avatar Brandon Labuschagne

Merge branch '287630-remove-ff-usage_data_design_action' into 'master'

[Feature flag] Remove usage_data_design_action feature flag [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!68534
parents d3af6779 9ea9f55d
......@@ -309,9 +309,7 @@ export default {
this.isLatestVersion,
);
if (this.glFeatures.usageDataDesignAction) {
servicePingDesignDetailView();
}
servicePingDesignDetailView();
},
updateActiveDiscussion(id, source = ACTIVE_DISCUSSION_SOURCE_TYPES.discussion) {
this.$apollo.mutate({
......
......@@ -42,7 +42,6 @@ class Projects::IssuesController < Projects::ApplicationController
before_action do
push_frontend_feature_flag(:tribute_autocomplete, @project)
push_frontend_feature_flag(:vue_issuables_list, project)
push_frontend_feature_flag(:usage_data_design_action, project, default_enabled: true)
push_frontend_feature_flag(:improved_emoji_picker, project, default_enabled: :yaml)
push_frontend_feature_flag(:vue_issues_list, project)
push_frontend_feature_flag(:iteration_cadences, project&.group, default_enabled: :yaml)
......
---
name: usage_data_design_action
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46626
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/287630
milestone: '13.7'
type: development
group: group::product planning
default_enabled: true
......@@ -67,7 +67,6 @@
- name: design_action
category: source_code
aggregation: daily
feature_flag: usage_data_design_action
- name: project_action
category: source_code
aggregation: daily
......
......@@ -390,28 +390,13 @@ describe('Design management design index page', () => {
);
});
describe('with usage_data_design_action enabled', () => {
it('tracks design view service ping', () => {
createComponent(
{ loading: true },
{
provide: {
glFeatures: { usageDataDesignAction: true },
},
},
);
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(
DESIGN_SERVICE_PING_EVENT_TYPES.DESIGN_ACTION,
);
});
});
it('tracks design view service ping', () => {
createComponent({ loading: true });
describe('with usage_data_design_action disabled', () => {
it("doesn't track design view service ping", () => {
createComponent({ loading: true });
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(0);
});
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(
DESIGN_SERVICE_PING_EVENT_TYPES.DESIGN_ACTION,
);
});
});
});
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment