Commit 955136b5 authored by Rémy Coutable's avatar Rémy Coutable

Don't fail the job if the Review App doesn't deploy properly

It seems the deploy function causes the job to fail if it doesn't
succeed. That wasn't the intent as we want to curl the Review App after
the deploy finished (even if it failed) because sometimes the Review App
is just a bit long to be ready.

This change wraps the Review App deployment with "set +e"/"set -e" to
ensure that the job doesn't fail right away if the deploy fails.
Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent b57e3358
...@@ -109,7 +109,7 @@ function perform_review_app_deployment() { ...@@ -109,7 +109,7 @@ function perform_review_app_deployment() {
ensure_namespace ensure_namespace
install_tiller install_tiller
install_external_dns install_external_dns
time deploy || true time deploy
wait_for_review_app_to_be_accessible wait_for_review_app_to_be_accessible
add_license add_license
} }
...@@ -270,7 +270,7 @@ EOF ...@@ -270,7 +270,7 @@ EOF
echoinfo "Deploying with:" echoinfo "Deploying with:"
echoinfo "${HELM_CMD}" echoinfo "${HELM_CMD}"
eval $HELM_CMD eval $HELM_CMD || true
} }
function wait_for_review_app_to_be_accessible() { function wait_for_review_app_to_be_accessible() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment