Merge branch 'xanf/fix-operations-on-destroyed-wrappers' into 'master'

Fix operations on destroyed wrappers

See merge request gitlab-org/gitlab!50098

ee/spec/frontend/security_configuration/dast_profiles/components/dast_profiles_spec.js

@@ -92,6 +92,8 @@ describe('EE - DastProfiles', () => {
     });
 
     it(`shows a "Scanner Profile" dropdown item that links to ${TEST_NEW_DAST_SCANNER_PROFILE_PATH}`, () => {
+      createComponent();
+
       expect(getSiteProfilesDropdownItem('Scanner Profile').getAttribute('href')).toBe(
         TEST_NEW_DAST_SCANNER_PROFILE_PATH,
       );

spec/frontend/alert_management/components/alert_details_spec.js

@@ -3,6 +3,7 @@ import { mount, shallowMount } from '@vue/test-utils';
 import axios from 'axios';
 import MockAdapter from 'axios-mock-adapter';
 import { extendedWrapper } from 'helpers/vue_test_utils_helper';
+import waitForPromises from 'helpers/wait_for_promises';
 import AlertDetails from '~/alert_management/components/alert_details.vue';
 import AlertSummaryRow from '~/alert_management/components/alert_summary_row.vue';
 import {
@@ -201,6 +202,11 @@ describe('AlertDetails', () => {
 
       it('calls `$apollo.mutate` with `createIssueQuery`', () => {
         const issueIid = '10';
+        mountComponent({
+          mountMethod: mount,
+          data: { alert: { ...mockAlert } },
+        });
+
         jest
           .spyOn(wrapper.vm.$apollo, 'mutate')
           .mockResolvedValue({ data: { createAlertIssue: { issue: { iid: issueIid } } } });
@@ -215,7 +221,7 @@ describe('AlertDetails', () => {
         });
       });
 
-      it('shows error alert when incident creation fails ', () => {
+      it('shows error alert when incident creation fails ', async () => {
         const errorMsg = 'Something went wrong';
         mountComponent({
           mountMethod: mount,
@@ -225,9 +231,8 @@ describe('AlertDetails', () => {
         jest.spyOn(wrapper.vm.$apollo, 'mutate').mockRejectedValue(errorMsg);
         findCreateIncidentBtn().trigger('click');
 
-        setImmediate(() => {
-          expect(findIncidentCreationAlert().text()).toBe(errorMsg);
-        });
+        await waitForPromises();
+        expect(findIncidentCreationAlert().text()).toBe(errorMsg);
       });
     });
 

spec/frontend/clusters/components/uninstall_application_button_spec.js

@@ -24,7 +24,7 @@ describe('UninstallApplicationButton', () => {
     ${UPDATING}     | ${false} | ${true}  | ${'Uninstall'}
     ${UNINSTALLING} | ${true}  | ${true}  | ${'Uninstalling'}
   `('when app status is $status', ({ loading, disabled, status, text }) => {
-    beforeAll(() => {
+    beforeEach(() => {
       createComponent({ status });
     });
 

spec/frontend/design_management/components/toolbar/index_spec.js

@@ -116,6 +116,8 @@ describe('Design management toolbar component', () => {
   });
 
   it('renders download button with correct link', () => {
+    createComponent();
+
     expect(wrapper.find(GlButton).attributes('href')).toBe(
       '/-/designs/306/7f747adcd4693afadbe968d7ba7d983349b9012d',
     );

spec/frontend/logs/components/log_advanced_filters_spec.js

@@ -73,6 +73,8 @@ describe('LogAdvancedFilters', () => {
   });
 
   it('displays search tokens', () => {
+    initWrapper();
+
     expect(getSearchToken(TOKEN_TYPE_POD_NAME)).toMatchObject({
       title: 'Pod name',
       unique: true,

spec/frontend/monitoring/components/alert_widget_form_spec.js

@@ -76,11 +76,15 @@ describe('AlertWidgetForm', () => {
   });
 
   it('shows correct title and button text', () => {
+    createComponent();
+
     expect(modalTitle()).toBe('Add alert');
     expect(submitButton().text()).toBe('Add');
   });
 
   it('sets tracking options for create alert', () => {
+    createComponent();
+
     expect(submitButtonTrackingOpts()).toEqual(dataTrackingOptions.create);
   });
 

spec/frontend/operation_settings/components/metrics_settings_spec.js

@@ -61,6 +61,7 @@ describe('operation settings external dashboard component', () => {
 
   describe('expand/collapse button', () => {
     it('renders as an expand button by default', () => {
+      mountComponent();
       const button = wrapper.find(GlButton);
 
       expect(button.text()).toBe('Expand');

spec/frontend/vue_mr_widget/components/mr_widget_pipeline_container_spec.js

@@ -94,6 +94,8 @@ describe('MrWidgetPipelineContainer', () => {
 
   describe('with artifacts path', () => {
     it('renders the artifacts app', () => {
+      factory();
+
       expect(wrapper.find(ArtifactsApp).isVisible()).toBe(true);
     });
   });

spec/frontend/vue_mr_widget/components/states/mr_widget_commits_header_spec.js

@@ -98,6 +98,8 @@ describe('Commits header component', () => {
     });
 
     it('does has merge commit part of the message', () => {
+      createComponent();
+
       expect(findHeaderWrapper().text()).toContain('1 merge commit');
     });
   });

spec/frontend/vue_shared/components/user_popover/user_popover_spec.js

@@ -81,6 +81,7 @@ describe('User Popover Component', () => {
     });
 
     it('shows icon for location', () => {
+      createWrapper();
       const iconEl = wrapper.find(GlIcon);
 
       expect(iconEl.props('name')).toEqual('location');