Merge branch 'remove-ci-templates-usage-data-ff' into 'master'

Remove feature flag usage_data_track_ci_templates_unique_projects [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!57280

changelogs/unreleased/remove-ci-templates-usage-data-ff.yml

+---
+title: Remove feature flag usage_data_track_ci_templates_unique_projects
+merge_request: 57280
+author:
+type: changed

config/feature_flags/development/usage_data_track_ci_templates_unique_projects.yml

----
-name: usage_data_track_ci_templates_unique_projects
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50481
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/296880
-milestone: '13.8'
-type: development
-group: group::configure
-default_enabled: true

lib/gitlab/usage_data_counters/ci_template_unique_counter.rb

@@ -20,8 +20,6 @@ module Gitlab::UsageDataCounters
 
     class << self
       def track_unique_project_event(project_id:, template:, config_source:)
-        return if Feature.disabled?(:usage_data_track_ci_templates_unique_projects, default_enabled: :yaml)
-
         if event = unique_project_event(template, config_source)
           Gitlab::UsageDataCounters::HLLRedisCounter.track_event(event, values: project_id)
         end

lib/gitlab/usage_data_counters/known_events/ci_templates.yml

@@ -3,89 +3,74 @@
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_implicit_auto_devops_build
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_implicit_auto_devops_deploy
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_implicit_security_sast
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_implicit_security_secret_detection
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 # Explicit include:template pipeline events
 - name: p_ci_templates_5_min_production_app
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_auto_devops
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_aws_cf_deploy_ec2
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_aws_deploy_ecs
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_auto_devops_build
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_auto_devops_deploy
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_auto_devops_deploy_latest
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_security_sast
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_security_secret_detection
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects
 
 - name: p_ci_templates_terraform_base_latest
   category: ci_templates
   redis_slot: ci_templates
   aggregation: weekly
-  feature_flag: usage_data_track_ci_templates_unique_projects