Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
994d9188
Commit
994d9188
authored
Sep 11, 2018
by
James Lopez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix avatar restorer
parent
6e394c44
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
11 deletions
+24
-11
lib/gitlab/import_export/avatar_restorer.rb
lib/gitlab/import_export/avatar_restorer.rb
+1
-1
spec/lib/gitlab/import_export/avatar_restorer_spec.rb
spec/lib/gitlab/import_export/avatar_restorer_spec.rb
+23
-10
No files found.
lib/gitlab/import_export/avatar_restorer.rb
View file @
994d9188
...
@@ -19,7 +19,7 @@ module Gitlab
...
@@ -19,7 +19,7 @@ module Gitlab
private
private
def
avatar_export_file
def
avatar_export_file
@avatar_export_file
||=
Dir
[
"
#{
avatar_export_path
}
/**/*"
].
first
@avatar_export_file
||=
Dir
[
"
#{
avatar_export_path
}
/**/*"
].
reject
{
|
f
|
File
.
directory?
(
f
)
}.
first
end
end
def
avatar_export_path
def
avatar_export_path
...
...
spec/lib/gitlab/import_export/avatar_restorer_spec.rb
View file @
994d9188
...
@@ -6,22 +6,35 @@ describe Gitlab::ImportExport::AvatarRestorer do
...
@@ -6,22 +6,35 @@ describe Gitlab::ImportExport::AvatarRestorer do
let
(
:shared
)
{
project
.
import_export_shared
}
let
(
:shared
)
{
project
.
import_export_shared
}
let
(
:project
)
{
create
(
:project
)
}
let
(
:project
)
{
create
(
:project
)
}
before
do
allow_any_instance_of
(
described_class
).
to
receive
(
:avatar_export_file
)
.
and_return
(
uploaded_image_temp_path
)
end
after
do
after
do
project
.
remove_avatar!
project
.
remove_avatar!
end
end
it
'restores a project avatar'
do
context
'with avatar'
do
expect
(
described_class
.
new
(
project:
project
,
shared:
shared
).
restore
).
to
be
true
before
do
allow_any_instance_of
(
described_class
).
to
receive
(
:avatar_export_file
)
.
and_return
(
uploaded_image_temp_path
)
end
it
'restores a project avatar'
do
expect
(
described_class
.
new
(
project:
project
,
shared:
shared
).
restore
).
to
be
true
end
it
'saves the avatar into the project'
do
described_class
.
new
(
project:
project
,
shared:
shared
).
restore
expect
(
project
.
reload
.
avatar
.
file
.
exists?
).
to
be
true
end
end
end
it
'saves the avatar into the project'
do
it
'does not break if there is just a directory'
do
described_class
.
new
(
project:
project
,
shared:
shared
).
restore
Dir
.
mktmpdir
do
|
tmpdir
|
FileUtils
.
mkdir_p
(
"
#{
tmpdir
}
/a/b"
)
allow_any_instance_of
(
described_class
).
to
receive
(
:avatar_export_path
)
.
and_return
(
"
#{
tmpdir
}
/a"
)
expect
(
project
.
reload
.
avatar
.
file
.
exists?
).
to
be
true
expect
(
described_class
.
new
(
project:
project
,
shared:
shared
).
restore
).
to
be
true
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment