Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
99624821
Commit
99624821
authored
Feb 09, 2021
by
Nicolò Maria Mezzopera
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix group path passing
- fix group path to full pat - add feature test
parent
3ba3bf52
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
1 deletion
+19
-1
app/views/groups/settings/packages_and_registries/index.html.haml
...s/groups/settings/packages_and_registries/index.html.haml
+1
-1
spec/features/groups/settings/packages_and_registries_spec.rb
.../features/groups/settings/packages_and_registries_spec.rb
+18
-0
No files found.
app/views/groups/settings/packages_and_registries/index.html.haml
View file @
99624821
...
...
@@ -2,4 +2,4 @@
-
page_title
_
(
'Packages & Registries'
)
-
@content_class
=
'limit-container-width'
unless
fluid_layout
%section
#js-packages-and-registries-settings
{
data:
{
default_expanded:
expanded_by_default?
.
to_s
,
group_path:
@group
.
path
}
}
%section
#js-packages-and-registries-settings
{
data:
{
default_expanded:
expanded_by_default?
.
to_s
,
group_path:
@group
.
full_
path
}
}
spec/features/groups/settings/packages_and_registries_spec.rb
View file @
99624821
...
...
@@ -7,9 +7,11 @@ RSpec.describe 'Group Packages & Registries settings' do
let
(
:user
)
{
create
(
:user
)
}
let
(
:group
)
{
create
(
:group
)
}
let
(
:sub_group
)
{
create
(
:group
,
parent:
group
)
}
before
do
group
.
add_owner
(
user
)
sub_group
.
add_owner
(
user
)
sign_in
(
user
)
end
...
...
@@ -85,6 +87,18 @@ RSpec.describe 'Group Packages & Registries settings' do
expect
(
page
).
to
have_content
(
'is an invalid regexp'
)
end
context
'in a sub group'
do
it
'works correctly'
,
:js
do
visit_sub_group_settings_page
expect
(
page
).
to
have_content
(
'Allow duplicates'
)
find
(
'.gl-toggle'
).
click
expect
(
page
).
to
have_content
(
'Do not allow duplicates'
)
end
end
end
def
find_settings_menu
...
...
@@ -94,4 +108,8 @@ RSpec.describe 'Group Packages & Registries settings' do
def
visit_settings_page
visit
group_settings_packages_and_registries_path
(
group
)
end
def
visit_sub_group_settings_page
visit
group_settings_packages_and_registries_path
(
sub_group
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment