Fix yamllint violations in metrics yamls

There were multiple metrics with duplicate keys
and other violations, so this fixes all violations
except for line length.

config/metrics/aggregates/common.yml

 # Aggregated metrics that include EE only event names within `events:` attribute have to be defined at ee/config/metrics/aggregates/common.yml
 # instead of this file.
-#- name: unique name of aggregated metric
+# - name: unique name of aggregated metric
 #  operator: aggregation operator. Valid values are:
 #             - "OR": counts unique elements that were observed triggering any of following events
 #             - "AND": counts unique elements that were observed triggering all of following events

config/metrics/counts_28d/20210201124930_deployments.yml

@@ -5,7 +5,7 @@ description: Total deployments count for recent 28 days
 product_section: ops
 product_stage: release
 product_group: group::ops release
-product_category: 
+product_category:
 value_type: number
 status: active
 milestone: "13.2"

config/metrics/counts_28d/20210216174956_i_analytics_cohorts_monthly.yml

 ---
 data_category: optional
 key_path: redis_hll_counters.analytics.i_analytics_cohorts_monthly
-description:  "Unique visitors to /-/instance_statistics/cohorts"
+description: "Unique visitors to /-/instance_statistics/cohorts"
 product_section: fulfillment
 product_stage: fulfillment
 product_group: group::utilization

config/metrics/counts_28d/20210216184140_testing_total_unique_counts_monthly.yml

@@ -2,7 +2,6 @@
 data_category: optional
 key_path: redis_hll_counters.testing.testing_total_unique_counts_monthly
 description: Total users for events under testing category
-product_section: devops
 product_section: growth
 product_stage: growth
 product_group: group::product intelligence

config/metrics/counts_28d/20210222041235_i_quickactions_invite_email_multiple_monthly.yml

@@ -20,7 +20,5 @@ distribution:
 - ce
 tier:
 - free
-tier:
-- free
 - premium
 - ultimate

config/metrics/counts_28d/20210427103010_code_review_extension_category_monthly_active_users.yml

@@ -5,7 +5,7 @@ description: Number of users performing i_code_review_user_vs_code_api_request e
 product_section: dev
 product_stage: devops::create
 product_group: group::code review
-product_category: 
+product_category:
 value_type: number
 status: active
 milestone: "13.12"

config/metrics/counts_28d/20210427103119_code_review_group_monthly_active_users.yml

@@ -5,7 +5,7 @@ description: Number of users performing at least one of the code review events
 product_section: dev
 product_stage: devops::create
 product_group: group::code review
-product_category: 
+product_category:
 value_type: number
 status: active
 milestone: "13.12"

config/metrics/counts_28d/20210514013545_i_code_review_user_resolve_conflict_monthly.yml

@@ -3,7 +3,6 @@ data_category: optional
 key_path: redis_hll_counters.code_review.i_code_review_user_resolve_conflict_monthly
 name: resolve_conflict
 description: Count of unique users per week who attempt to resolve a conflict through the ui
-product_section:
 product_stage: create
 product_group: group::code review
 product_category: code_review

config/metrics/counts_28d/20210514013549_i_code_review_user_load_conflict_ui_monthly.yml

@@ -3,7 +3,6 @@ data_category: optional
 key_path: redis_hll_counters.code_review.i_code_review_user_load_conflict_ui_monthly
 name: load_conflict_ui
 description: Count of unique users per week who load the conflict resolution page
-product_section:
 product_stage: create
 product_group: group::code review
 product_category: code_review

config/metrics/counts_28d/20210902191057_i_quickactions_unapprove_monthly.yml

@@ -12,10 +12,6 @@ milestone: "14.3"
 time_frame: 28d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options:
-  events:
-    - i_quickactions_unapprove
-instrumentation_class: RedisHLLMetric
 options:
   events:
     - i_quickactions_unapprove

config/metrics/counts_28d/20211201140658_users_expanding_testing_license_compliance_report_monthly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75643
 time_frame: 28d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_expanding_testing_license_compliance_report
 distribution:
   - ce

config/metrics/counts_28d/20211201154341_users_visiting_license_compliance_full_report_monthly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75643
 time_frame: 28d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_visiting_testing_license_compliance_full_report
 distribution:
   - ce

config/metrics/counts_28d/20211202094237_users_visiting_manage_license_compliance_monthly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75643
 time_frame: 28d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_visiting_testing_manage_license_compliance
 distribution:
   - ce

config/metrics/counts_28d/20211216083832_users_clicking_license_testing_visiting_external_website_monthly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/76917
 time_frame: 28d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_clicking_license_testing_visiting_external_website
 distribution:
   - ce
@@ -22,4 +22,4 @@ distribution:
 tier:
   - free
   - premium
-  - ultimate
\ No newline at end of file
+  - ultimate

config/metrics/counts_7d/20210216184508_p_ci_templates_implicit_security_sast_weekly.yml

@@ -15,7 +15,6 @@ options:
   events:
   - p_ci_templates_implicit_security_sast
 distribution:
-distribution:
 - ce
 - ee
 tier:

config/metrics/counts_7d/20210216184536_p_ci_templates_auto_devops_deploy_weekly.yml

@@ -25,4 +25,3 @@ tier:
 - premium
 - ultimate
 performance_indicator_type: []
-milestone: "<13.9"

config/metrics/counts_7d/20210427103328_code_review_group_monthly_active_users.yml

@@ -18,4 +18,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_7d/20210427103407_code_review_category_monthly_active_users.yml

@@ -19,4 +19,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_7d/20210902191054_i_quickactions_unapprove_weekly.yml

@@ -12,10 +12,6 @@ milestone: "14.3"
 time_frame: 7d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options:
-  events:
-    - i_quickactions_unapprove
-instrumentation_class: RedisHLLMetric
 options:
   events:
     - i_quickactions_unapprove

config/metrics/counts_7d/20211126154206_users_expanding_testing_license_compliance_report_weekly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75643
 time_frame: 7d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_expanding_testing_license_compliance_report
 distribution:
   - ce

config/metrics/counts_7d/20211201154118_users_visiting_license_compliance_full_report_weekly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75643
 time_frame: 7d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_visiting_testing_license_compliance_full_report
 distribution:
   - ce

config/metrics/counts_7d/20211202094430_users_visiting_manage_license_compliance_weekly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75643
 time_frame: 7d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_visiting_testing_manage_license_compliance
 distribution:
   - ce

config/metrics/counts_7d/20211216084934_users_clicking_license_testing_visiting_external_website_weekly.yml

@@ -13,8 +13,8 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/76917
 time_frame: 7d
 data_source: redis_hll
 instrumentation_class: RedisHLLMetric
-options: 
-  events: 
+options:
+  events:
     - users_clicking_license_testing_visiting_external_website
 distribution:
   - ce

config/metrics/counts_all/20210216183023_wiki_pages_view.yml

@@ -20,4 +20,3 @@ tier:
 - premium
 - ultimate
 performance_indicator_type: []
-milestone: "<13.9"

config/metrics/counts_all/20210303153004_package_events_i_package_rubygems_push_package.yml

@@ -19,4 +19,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210423005644_i_analytics_dev_ops_adoption.yml

@@ -18,4 +18,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210505015532_kubernetes_agent_k8s_api_proxy_request.yml

@@ -9,7 +9,7 @@ product_category: kubernetes_management
 value_type: number
 status: active
 milestone: '13.12'
-introduced_by_url: 
+introduced_by_url:
 time_frame: all
 data_source: redis
 distribution:

config/metrics/counts_all/20210510201919_in_product_marketing_email_create_0_cta_clicked.yml

@@ -20,4 +20,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210510202356_in_product_marketing_email_create_1_cta_clicked.yml

@@ -20,4 +20,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210510203005_in_product_marketing_email_verify_1_cta_clicked.yml

@@ -20,4 +20,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210510203104_in_product_marketing_email_trial_1_cta_clicked.yml

@@ -20,4 +20,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210510203203_in_product_marketing_email_team_1_cta_clicked.yml

@@ -20,4 +20,3 @@ tier:
 - free
 - premium
 - ultimate
-

config/metrics/counts_all/20210709210941_package_events_i_package_pull_symbol_package.yml

@@ -19,4 +19,4 @@ distribution:
 tier:
 - free
 - premium
-- ultimate
\ No newline at end of file
+- ultimate

config/metrics/counts_all/20210709211248_package_events_i_package_pull_symbol_package_by_guest.yml

@@ -19,4 +19,4 @@ distribution:
 tier:
 - free
 - premium
-- ultimate
\ No newline at end of file
+- ultimate

config/metrics/settings/20210323120839_topology.yml

@@ -5,7 +5,7 @@ description: Topology data
 product_section: enablement
 product_stage: enablement
 product_group: group::memory
-product_category: 
+product_category:
 value_type: object
 status: active
 milestone: "13.11"