Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9d882321
Commit
9d882321
authored
Dec 18, 2019
by
Nicolò Maria Mezzopera
Committed by
Natalia Tepluhina
Dec 18, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update gl-table to use stacked on sm breakpoint
- updated snapshots
parent
cff37dd7
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
94 additions
and
54 deletions
+94
-54
ee/app/assets/javascripts/packages/list/components/packages_list.vue
...ts/javascripts/packages/list/components/packages_list.vue
+1
-0
ee/app/assets/javascripts/packages/list/components/packages_list_app.vue
...avascripts/packages/list/components/packages_list_app.vue
+1
-1
ee/spec/frontend/packages/list/components/__snapshots__/packages_list_spec.js.snap
.../list/components/__snapshots__/packages_list_spec.js.snap
+85
-53
ee/spec/frontend/packages/list/components/packages_list_spec.js
...c/frontend/packages/list/components/packages_list_spec.js
+7
-0
No files found.
ee/app/assets/javascripts/packages/list/components/packages_list.vue
View file @
9d882321
...
...
@@ -176,6 +176,7 @@ export default {
:items=
"list"
:fields=
"headerFields"
:no-local-sorting=
"true"
stacked=
"md"
>
<template
#name
="
{value}">
<div
ref=
"col-name"
class=
"flex-truncate-parent"
>
...
...
ee/app/assets/javascripts/packages/list/components/packages_list_app.vue
View file @
9d882321
...
...
@@ -46,7 +46,7 @@ export default {
</
script
>
<
template
>
<gl-loading-icon
v-if=
"isLoading"
/>
<gl-loading-icon
v-if=
"isLoading"
class=
"mt-2"
/>
<package-list
v-else
@
page:changed=
"onPageChanged"
@
package:delete=
"onPackageDeleteRequest"
>
<template
#empty-state
>
<gl-empty-state
...
...
ee/spec/frontend/packages/list/components/__snapshots__/packages_list_spec.js.snap
View file @
9d882321
...
...
@@ -35,8 +35,10 @@ exports[`packages_list renders 1`] = `
<table
aria-busy="false"
aria-colcount="5"
class="table b-table gl-table"
aria-describedby="__BVID__9__caption_"
class="table b-table gl-table b-table-stacked-md"
id="__BVID__9"
role="table"
>
<!---->
<!---->
...
...
@@ -104,66 +106,81 @@ exports[`packages_list renders 1`] = `
<td
aria-colindex="1"
class="text-left"
data-label="Name"
role="cell"
>
<div
class="flex-truncate-parent"
>
<a
class="flex-truncate-child"
data-qa-selector="package_link"
href="#"
<div>
<div
class="flex-truncate-parent"
>
<a
class="flex-truncate-child"
data-qa-selector="package_link"
href="#"
>
Test package
</a>
</a>
</div>
</div>
</td>
<td
aria-colindex="2"
class="text-center"
data-label="Version"
role="cell"
>
<div>
1.0.0
</div>
</td>
<td
aria-colindex="3"
class="text-center"
data-label="Type"
role="cell"
>
<div>
maven
</div>
</td>
<td
aria-colindex="4"
class="text-center"
data-label="Created"
role="cell"
>
<timeagotooltip-stub
cssclass=""
time=""
tooltipplacement="top"
/>
<div>
<timeagotooltip-stub
cssclass=""
time=""
tooltipplacement="top"
/>
</div>
</td>
<td
aria-colindex="5"
class="text-right"
data-label=""
role="cell"
>
<glbutton-stub
aria-label="Remove package"
title="Remove package"
variant="danger"
>
<icon-stub
name="remove"
size="16"
/>
</glbutton-stub>
<div>
<glbutton-stub
aria-label="Remove package"
title="Remove package"
variant="danger"
>
<icon-stub
name="remove"
size="16"
/>
</glbutton-stub>
</div>
</td>
</tr>
<tr
...
...
@@ -173,66 +190,81 @@ exports[`packages_list renders 1`] = `
<td
aria-colindex="1"
class="text-left"
data-label="Name"
role="cell"
>
<div
class="flex-truncate-parent"
>
<a
class="flex-truncate-child"
data-qa-selector="package_link"
href="#"
<div>
<div
class="flex-truncate-parent"
>
<a
class="flex-truncate-child"
data-qa-selector="package_link"
href="#"
>
@Test/package
</a>
</a>
</div>
</div>
</td>
<td
aria-colindex="2"
class="text-center"
data-label="Version"
role="cell"
>
<div>
</div>
</td>
<td
aria-colindex="3"
class="text-center"
data-label="Type"
role="cell"
>
<div>
npm
</div>
</td>
<td
aria-colindex="4"
class="text-center"
data-label="Created"
role="cell"
>
<timeagotooltip-stub
cssclass=""
time=""
tooltipplacement="top"
/>
<div>
<timeagotooltip-stub
cssclass=""
time=""
tooltipplacement="top"
/>
</div>
</td>
<td
aria-colindex="5"
class="text-right"
data-label=""
role="cell"
>
<glbutton-stub
aria-label="Remove package"
title="Remove package"
variant="danger"
>
<icon-stub
name="remove"
size="16"
/>
</glbutton-stub>
<div>
<glbutton-stub
aria-label="Remove package"
title="Remove package"
variant="danger"
>
<icon-stub
name="remove"
size="16"
/>
</glbutton-stub>
</div>
</td>
</tr>
<!---->
...
...
ee/spec/frontend/packages/list/components/packages_list_spec.js
View file @
9d882321
...
...
@@ -173,4 +173,11 @@ describe('packages_list', () => {
expect
(
wrapper
.
emitted
(
'
page:changed
'
)).
toEqual
([[
2
]]);
});
});
describe
(
'
table component
'
,
()
=>
{
it
(
'
has stacked-md class
'
,
()
=>
{
const
table
=
findPackageListTable
();
expect
(
table
.
classes
()).
toContain
(
'
b-table-stacked-md
'
);
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment