Commit 9e6cdc64 authored by Adam Niedzielski's avatar Adam Niedzielski

Revert "Pass correct tag target to post-receive hook when creating tag via UI"

This reverts commit ae51774b.
parent 6ea0b8d5
...@@ -196,18 +196,11 @@ class Repository ...@@ -196,18 +196,11 @@ class Repository
options = { message: message, tagger: user_to_committer(user) } if message options = { message: message, tagger: user_to_committer(user) } if message
rugged.tags.create(tag_name, target, options) GitHooksService.new.execute(user, path_to_repo, oldrev, target, ref) do
tag = find_tag(tag_name) rugged.tags.create(tag_name, target, options)
GitHooksService.new.execute(user, path_to_repo, oldrev, tag.target, ref) do
# we already created a tag, because we need tag SHA to pass correct
# values to hooks
end end
tag find_tag(tag_name)
rescue GitHooksService::PreReceiveError
rugged.tags.delete(tag_name)
raise
end end
def rm_branch(user, branch_name) def rm_branch(user, branch_name)
......
...@@ -1303,28 +1303,6 @@ describe Repository, models: true do ...@@ -1303,28 +1303,6 @@ describe Repository, models: true do
repository.add_tag(user, '8.5', 'master', 'foo') repository.add_tag(user, '8.5', 'master', 'foo')
end end
it 'does not create a tag when a pre-hook fails' do
allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
expect do
repository.add_tag(user, '8.5', 'master', 'foo')
end.to raise_error(GitHooksService::PreReceiveError)
repository.expire_tags_cache
expect(repository.find_tag('8.5')).to be_nil
end
it 'passes tag SHA to hooks' do
spy = GitHooksService.new
allow(GitHooksService).to receive(:new).and_return(spy)
allow(spy).to receive(:execute).and_call_original
tag = repository.add_tag(user, '8.5', 'master', 'foo')
expect(spy).to have_received(:execute).
with(anything, anything, anything, tag.target, anything)
end
it 'returns a Gitlab::Git::Tag object' do it 'returns a Gitlab::Git::Tag object' do
tag = repository.add_tag(user, '8.5', 'master', 'foo') tag = repository.add_tag(user, '8.5', 'master', 'foo')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment