Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a23b2e05
Commit
a23b2e05
authored
Mar 26, 2019
by
James Fargher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix ChatOps Slack responder for gitlab.com
The responder method can only exist on a Service model subclass
parent
a3cd7259
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
20 additions
and
12 deletions
+20
-12
ee/app/models/project_services/gitlab_slack_application_service.rb
...dels/project_services/gitlab_slack_application_service.rb
+4
-0
ee/app/services/projects/slack_application_install_service.rb
...pp/services/projects/slack_application_install_service.rb
+0
-4
ee/changelogs/unreleased/fix_chatops_responder.yml
ee/changelogs/unreleased/fix_chatops_responder.yml
+5
-0
ee/spec/models/project_services/gitlab_slack_application_service_spec.rb
...project_services/gitlab_slack_application_service_spec.rb
+11
-0
ee/spec/services/projects/slack_application_install_service_spec.rb
...rvices/projects/slack_application_install_service_spec.rb
+0
-8
No files found.
ee/app/models/project_services/gitlab_slack_application_service.rb
View file @
a23b2e05
...
...
@@ -40,4 +40,8 @@ class GitlabSlackApplicationService < Service
def
fields
[]
end
def
chat_responder
Gitlab
::
Chat
::
Responder
::
Slack
end
end
ee/app/services/projects/slack_application_install_service.rb
View file @
a23b2e05
...
...
@@ -30,10 +30,6 @@ module Projects
success
end
def
chat_responder
Gitlab
::
Chat
::
Responder
::
Slack
end
private
# rubocop: disable CodeReuse/ActiveRecord
...
...
ee/changelogs/unreleased/fix_chatops_responder.yml
0 → 100644
View file @
a23b2e05
---
title
:
Fix ChatOps Slack responder for gitlab.com
merge_request
:
10416
author
:
type
:
fixed
ee/spec/models/project_services/gitlab_slack_application_service_spec.rb
0 → 100644
View file @
a23b2e05
# frozen_string_literal: true
require
'spec_helper'
describe
GitlabSlackApplicationService
do
describe
'#chat_responder'
do
it
'returns the chat responder to use'
do
expect
(
subject
.
chat_responder
).
to
eq
(
Gitlab
::
Chat
::
Responder
::
Slack
)
end
end
end
ee/spec/services/projects/slack_application_install_service_spec.rb
View file @
a23b2e05
...
...
@@ -46,12 +46,4 @@ describe Projects::SlackApplicationInstallService do
expect_slack_integration_is_created
(
project
)
expect_chat_name_is_created
(
project
)
end
describe
'#chat_responder'
do
it
'returns the chat responder to use'
do
srv
=
service
expect
(
srv
.
chat_responder
).
to
eq
(
Gitlab
::
Chat
::
Responder
::
Slack
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment