Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a2bdc67c
Commit
a2bdc67c
authored
May 14, 2020
by
Sam Kerr
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add scanner name
parent
167b7088
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
53 additions
and
6 deletions
+53
-6
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table.vue
...ecurity_dashboard/components/security_dashboard_table.vue
+3
-0
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue
...ity_dashboard/components/security_dashboard_table_row.vue
+11
-0
ee/app/assets/javascripts/security_dashboard/helpers.js
ee/app/assets/javascripts/security_dashboard/helpers.js
+1
-1
ee/app/assets/javascripts/security_dashboard/store/modules/filters/constants.js
...pts/security_dashboard/store/modules/filters/constants.js
+1
-1
ee/app/assets/javascripts/security_dashboard/store/modules/filters/state.js
...scripts/security_dashboard/store/modules/filters/state.js
+1
-1
ee/app/assets/javascripts/vulnerabilities/components/vulnerability_list.vue
...scripts/vulnerabilities/components/vulnerability_list.vue
+9
-0
ee/app/assets/javascripts/vulnerabilities/graphql/vulnerability.fragment.graphql
...ts/vulnerabilities/graphql/vulnerability.fragment.graphql
+1
-0
ee/changelogs/unreleased/add-scanner-name-to-row.yml
ee/changelogs/unreleased/add-scanner-name-to-row.yml
+5
-0
ee/spec/frontend/security_dashboard/components/security_dashboard_table_row_spec.js
...dashboard/components/security_dashboard_table_row_spec.js
+8
-0
ee/spec/frontend/vulnerabilities/mock_data.js
ee/spec/frontend/vulnerabilities/mock_data.js
+2
-0
ee/spec/frontend/vulnerabilities/vulnerability_list_spec.js
ee/spec/frontend/vulnerabilities/vulnerability_list_spec.js
+5
-0
locale/gitlab.pot
locale/gitlab.pot
+6
-3
No files found.
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table.vue
View file @
a2bdc67c
...
...
@@ -77,6 +77,9 @@ export default {
<div
class=
"table-section flex-grow-1"
role=
"rowheader"
>
{{
s__
(
'
Reports|Vulnerability
'
)
}}
</div>
<div
class=
"table-section section-15"
role=
"rowheader"
>
{{
s__
(
'
Reports|Scanner
'
)
}}
</div>
<div
class=
"table-section section-20"
role=
"rowheader"
></div>
</div>
...
...
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue
View file @
a2bdc67c
...
...
@@ -43,6 +43,10 @@ export default {
}
return
location
&&
(
location
.
image
||
location
.
file
||
location
.
path
);
},
vulnerabilityScanner
()
{
const
{
scanner
}
=
this
.
vulnerability
;
return
scanner
?.
name
;
},
isDismissed
()
{
return
Boolean
(
this
.
vulnerability
.
dismissal_feedback
);
},
...
...
@@ -135,6 +139,13 @@ export default {
</div>
</div>
<div
class=
"table-section section-15"
>
<div
class=
"table-mobile-header"
role=
"rowheader"
>
{{ s__('Reports|Scanner') }}
</div>
<div
class=
"table-mobile-content"
>
{{ vulnerabilityScanner }}
</div>
</div>
<div
class=
"table-section section-20"
>
<div
class=
"table-mobile-header"
role=
"rowheader"
>
{{ s__('Reports|Actions') }}
</div>
<div
class=
"table-mobile-content action-buttons d-flex justify-content-end"
>
...
...
ee/app/assets/javascripts/security_dashboard/helpers.js
View file @
a2bdc67c
...
...
@@ -27,7 +27,7 @@ export const initFirstClassVulnerabilityFilters = projects => {
selection
:
new
Set
([
ALL
]),
},
{
name
:
s__
(
'
SecurityReports|Report type
'
),
name
:
s__
(
'
Reports|Scanner
'
),
id
:
'
reportType
'
,
options
:
[
BASE_FILTERS
.
report_type
,
...
parseOptions
(
REPORT_TYPES
)],
selection
:
new
Set
([
ALL
]),
...
...
ee/app/assets/javascripts/security_dashboard/store/modules/filters/constants.js
View file @
a2bdc67c
...
...
@@ -8,7 +8,7 @@ export const BASE_FILTERS = {
id
:
ALL
,
},
report_type
:
{
name
:
s__
(
'
ciReport|All
report
types
'
),
name
:
s__
(
'
ciReport|All
scanner
types
'
),
id
:
ALL
,
},
project_id
:
{
...
...
ee/app/assets/javascripts/security_dashboard/store/modules/filters/state.js
View file @
a2bdc67c
...
...
@@ -14,7 +14,7 @@ export default () => ({
selection
:
new
Set
([
BASE_FILTERS
.
severity
.
id
]),
},
{
name
:
s__
(
'
SecurityReports|
Report
type
'
),
name
:
s__
(
'
SecurityReports|
Scanner
type
'
),
id
:
'
report_type
'
,
options
:
[
BASE_FILTERS
.
report_type
,
...
optionsObjectToArray
(
REPORT_TYPES
)],
hidden
:
false
,
...
...
ee/app/assets/javascripts/vulnerabilities/components/vulnerability_list.vue
View file @
a2bdc67c
...
...
@@ -93,6 +93,11 @@ export default {
label
:
__
(
'
Description
'
),
thClass
:
commonThClass
,
},
{
key
:
'
reportType
'
,
label
:
s__
(
'
Reports|Scanner
'
),
thClass
:
`
${
commonThClass
}
`
,
},
];
},
},
...
...
@@ -201,6 +206,10 @@ export default {
<remediated-badge
v-if=
"item.resolved_on_default_branch"
class=
"ml-2"
/>
</
template
>
<
template
#cell(reportType)=
"{ item }"
>
<span
class=
"text-capitalize js-reportType"
>
{{
item
.
reportType
}}
</span>
</
template
>
<
template
#table-busy
>
<gl-skeleton-loading
v-for=
"n in $options.VULNERABILITIES_PER_PAGE"
...
...
ee/app/assets/javascripts/vulnerabilities/graphql/vulnerability.fragment.graphql
View file @
a2bdc67c
...
...
@@ -4,6 +4,7 @@ fragment Vulnerability on Vulnerability {
state
severity
vulnerabilityPath
reportType
location
{
...
on
VulnerabilityLocationContainerScanning
{
image
...
...
ee/changelogs/unreleased/add-scanner-name-to-row.yml
0 → 100644
View file @
a2bdc67c
---
title
:
Add scanner name to vulnerability row
merge_request
:
31775
author
:
type
:
changed
ee/spec/frontend/security_dashboard/components/security_dashboard_table_row_spec.js
View file @
a2bdc67c
...
...
@@ -77,6 +77,14 @@ describe('Security Dashboard Table Row', () => {
).
toContain
(
wrapper
.
props
().
vulnerability
.
severity
);
});
it
(
'
should render the scanner name
'
,
()
=>
{
expect
(
findContent
(
2
)
.
text
()
.
toLowerCase
(),
).
toContain
(
wrapper
.
props
().
vulnerability
.
scanner
.
name
.
toLowerCase
());
});
describe
(
'
the project name
'
,
()
=>
{
it
(
'
should render the name
'
,
()
=>
{
expect
(
findContent
(
1
).
text
()).
toContain
(
wrapper
.
props
().
vulnerability
.
name
);
...
...
ee/spec/frontend/vulnerabilities/mock_data.js
View file @
a2bdc67c
...
...
@@ -4,6 +4,7 @@ export const generateVulnerabilities = () => [
title
:
'
Vulnerability 1
'
,
severity
:
'
critical
'
,
state
:
'
dismissed
'
,
reportType
:
'
sast
'
,
location
:
{
image
:
'
registry.gitlab.com/groulot/container-scanning-test/master:5f21de6956aee99ddb68ae49498662d9872f50ff
'
,
...
...
@@ -17,6 +18,7 @@ export const generateVulnerabilities = () => [
title
:
'
Vulnerability 2
'
,
severity
:
'
high
'
,
state
:
'
opened
'
,
reportType
:
'
sast
'
,
location
:
{
file
:
'
src/main/java/com/gitlab/security_products/tests/App.java
'
,
},
...
...
ee/spec/frontend/vulnerabilities/vulnerability_list_spec.js
View file @
a2bdc67c
...
...
@@ -63,6 +63,11 @@ describe('Vulnerability list component', () => {
expect
(
cell
.
text
().
toLowerCase
()).
toBe
(
newVulnerabilities
[
0
].
severity
);
});
it
(
'
should correctly render the scanner type
'
,
()
=>
{
const
cell
=
findCell
(
'
reportType
'
);
expect
(
cell
.
text
().
toLowerCase
()).
toBe
(
newVulnerabilities
[
0
].
reportType
);
});
it
(
'
should correctly render the description
'
,
()
=>
{
const
cell
=
findCell
(
'
description
'
);
...
...
locale/gitlab.pot
View file @
a2bdc67c
...
...
@@ -18028,6 +18028,9 @@ msgstr ""
msgid "Reports|Metrics reports failed loading results"
msgstr ""
msgid "Reports|Scanner"
msgstr ""
msgid "Reports|Severity"
msgstr ""
...
...
@@ -18981,10 +18984,10 @@ msgstr ""
msgid "SecurityReports|Remove project from dashboard"
msgstr ""
msgid "SecurityReports|Re
port type
"
msgid "SecurityReports|Re
turn to dashboard
"
msgstr ""
msgid "SecurityReports|
Return to dashboard
"
msgid "SecurityReports|
Scanner type
"
msgstr ""
msgid "SecurityReports|Security Dashboard"
...
...
@@ -25455,7 +25458,7 @@ msgstr ""
msgid "ciReport|All projects"
msgstr ""
msgid "ciReport|All
report
types"
msgid "ciReport|All
scanner
types"
msgstr ""
msgid "ciReport|All severities"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment